Closed Bug 1528071 Opened 6 years ago Closed 6 years ago

Reunify files that were de-unified for MSVC

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: glandium, Assigned: away)

References

Details

Attachments

(3 files)

Add include guards to StaticAtoms.py
(deleted), text/x-phabricator-request
Details
Move `GetAtomBase`s into classes to avoid unified name conflict.
(deleted), text/x-phabricator-request
Details
Re-unify some source files that had been de-unified for MSVC.
(deleted), text/x-phabricator-request
Details
Assignee: nobody → dmajor
Attached file Add include guards to StaticAtoms.py (deleted) —

This will make the headers more unified-build-friendly.

Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0d659b1c6de3 Add include guards to StaticAtoms.py r=heycam
Keywords: in-triage → leave-open
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/020e9abe510a Move `GetAtomBase`s into classes to avoid unified name conflict. r=heycam
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/398daf04b7cf Re-unify some source files that had been de-unified for MSVC. r=glandium
Keywords: leave-open

https://hg.mozilla.org/mozilla-central/rev/020e9abe510a
https://hg.mozilla.org/mozilla-central/rev/398daf04b7cf

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: