Closed Bug 1528090 Opened 6 years ago Closed 6 years ago

`pageActionSeparator` is now permanently visible

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- fixed

People

(Reporter: bruce.bugz, Assigned: yzen)

References

Details

(Keywords: regression)

Attachments

(1 file)

chrome://browser/skin/browser.css has:

#page-action-buttons > :not([hidden]) ~ #pageActionSeparator {
    visibility: visible;
}

which will now always apply because the newly introduced toolbartabstop child of #page-action-buttons precedes #pageActionSeparator.

Blocks: 1436086
Keywords: regression

I guess this is part of the styling fixes Yura is assigned to work on after this initial landing of the new keyboard nav stuff. See bug 1506510. NI'ing Yura for info.

Flags: needinfo?(yzenevich)
Assignee: nobody → yzenevich
Component: Toolbars and Customization → Theme
Priority: -- → P1
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

(In reply to Marco Zehe (:MarcoZ) from comment #1)

I guess this is part of the styling fixes Yura is assigned to work on after this initial landing of the new keyboard nav stuff. See bug 1506510. NI'ing Yura for info.

thanks

Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/autoland/rev/510bae6520ad ensure that the urlbar page action separator is not visible because of toolbartabstop. r=dao
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Fixed, removing ni

Flags: needinfo?(yzenevich)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: