Closed
Bug 1528150
Opened 6 years ago
Closed 6 years ago
Build gn from https://gn.googlesource.com/gn/
Categories
(Firefox Build System :: Toolchains, enhancement)
Firefox Build System
Toolchains
Tracking
(firefox67 fixed)
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
gn has moved to a standalone repository, which would save some serious time building gn, since it's currently dominated by cloning 3 git repositories, one of which is absolutely massive.
Assignee | ||
Comment 1•6 years ago
|
||
Make some adjustments to make the build work:
- On Linux, a newer GCC is needed, and -lrt is missing for
clock_gettime. - On Mac, ninja expect AR be accept ar arguments, which clang doesn't,
so use llvm-ar. - On Windows, remove the /WX flag that upstream sets (warnings as
errors) because there are warnings in the code, and remove the
explicit /MACHINE:x64 linker flag because we're building for x86.
(we could build for x64, but I'd rather leave that to a followup)
Assignee | ||
Comment 2•6 years ago
|
||
With this, bug 1528155 and bug 1527798, gn tasks on all platforms (!) finish in 3 minutes, instead of 20 for Linux and Mac and > 30 for Windows.
(In reply to Mike Hommey [:glandium] from comment #0)
gn has moved to a standalone repository, which would save some serious time
building gn, since it's currently dominated by cloning 3 git repositories,
one of which is absolutely massive.
Not to mention that the revision we build is so old that it can't be used for LLVM's gn build. Thanks for doing this.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0605b508a2c6
Build gn from https://gn.googlesource.com/gn/. r=froydnj
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7698adc8e90
Build gn from https://gn.googlesource.com/gn/. r=froydnj
Comment 6•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•