Closed Bug 1528200 Opened 6 years ago Closed 4 years ago

Glean fails to build on Windows if username contains a whitespace

Categories

(Data Platform and Tools :: Glean: SDK, defect, P3)

defect
Points:
2

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: Dexter, Unassigned)

References

Details

(Whiteboard: [telemetry:glean-rs:backlog])

That's how I spent my lucky hours today. Turns out my new Windows account has a whitespace in it, so does my user directory. While building glean, we invoke the Miniconda installer (through the gradle python envs plugin, to silently install python in the user's gradle directory. The command is the following:

Miniconda3-4.5.11-Windows-x86_64.exe /InstallationType=JustMe /AddToPath=0 /RegisterPython=0 /S "/D=C:\Users\User Name.gradle\glean\bootstrap-4.5.11\Miniconda3"

Apparently, the plugin tries to do the smart thing and wraps the path in double quotes, but documentation states it shouldn't.

To fix this, we should probably file a PR upstream to not wrap paths with spaces in doublequotes.

Blocks: 1491345
Priority: -- → P1
Whiteboard: [telemetry:mobilesdk:m?]
Priority: P1 → --

Ouch. You're always out on the bleeding edge.

If we can't fix this upstream in the plugin, maybe we could try to convert it to a DOS path before sending it to the plugin, e.g. like this in Powershell. Maybe Gradle/Groovy has an API for that, but I haven't been able to find it...

Priority: -- → P1
Whiteboard: [telemetry:mobilesdk:m?] → [telemetry:mobilesdk:m5]
Assignee: nobody → tlong
Assignee: tlong → nobody
Assignee: nobody → alessio.placitelli
Points: --- → 2
Assignee: alessio.placitelli → nobody
Whiteboard: [telemetry:mobilesdk:m5] → [telemetry:mobilesdk:backlog]
Priority: P1 → P3
Component: Telemetry → Glean: SDK
Product: Toolkit → Data Platform and Tools
Whiteboard: [telemetry:mobilesdk:backlog] → [telemetry:glean-rs:m?]
Whiteboard: [telemetry:glean-rs:m?] → [telemetry:glean-rs:backlog]
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.