Closed Bug 1528203 Opened 6 years ago Closed 6 years ago

Search bar does not show default search engine

Categories

(Firefox :: Search, defect, P1)

Product:
Firefox
Component:
Search
Version:
67 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- verified

People

(Reporter: Fanolian+BMO, Assigned: mikedeboer)

References

Details

(Keywords: regression, reproducible)

Attachments

(2 files)

Default search engine name missing
(deleted), image/png
Details
Bug 1528203 - Searchbar popups' `updateHeader` was using the wrong method signature to get the default search engine. r?florian!
(deleted), text/x-phabricator-request
Details
Attached image Default search engine name missing (deleted) —

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
Build ID: 20190215045130

Steps to reproduce

  1. Add search bar to toolbar.
  2. Click the magnifying glass to open drop down menu.

Actual result
The first row does not show the default engine name. Clicking on it does not do anything. (Please see attached screenshot.)

Expected result
Default search engine is shown so users are aware what engine they are using. A search is performed when the row is clicked.

It is a regression from bug 1524593.

Blocks: 1524593
Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: regression, reproducible
Status: UNCONFIRMED → NEW
status-firefox65: --- → unaffected
status-firefox66: --- → unaffected
status-firefox-esr60: --- → unaffected
Ever confirmed: true

Mike, it seems that your patch in bug 1524593 caused this regression. Could you have a look please? Thanks.

Flags: needinfo?(mdeboer)

Thanks for the report! Working on it.

Assignee: nobody → mdeboer
Flags: needinfo?(mdeboer)
Priority: -- → P1
Pushed by mdeboer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e48e5c70315f Searchbar popups' `updateHeader` was using the wrong method signature to get the default search engine. r=florian

https://hg.mozilla.org/mozilla-central/rev/e48e5c70315f

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

I have reproduced this bug with Nightly 67.0a1 (2019-02-15) on Windows 7, 64 Bit. The fix of this bug is verified with latest Beta 67.0b5!

Build ID 20190325125126
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

QA Whiteboard: [bugday-20190320]

I will mark this bug as Verified Fixed as per comment 6.

Status: RESOLVED → VERIFIED
status-firefox67: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: