[de-xbl] convert activity-group to custom element
Categories
(Thunderbird :: General, task)
Tracking
(Not tracked)
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #4)
Clicking an item (Deleted 4 messags from Inbox) after opening the Activity
Manager (possibly only while there is only one item in the list), I getJavaScript error: chrome://global/content/elements/richlistbox.js, line 397:
TypeError: aItem is nullremoveItemFromSelection(aItem)
--> if (!aItem.selected) {
I found this issue on trunk. It was behaving correctly so I am not sure what to do exactly so I have kept it for the end after converting related activity bindings.
When I move a message to another folder, I got this:
2019-02-20 12:15:41 nsActivityManager ERROR Exception calling
onAddedActivity[Exception... "[JavaScript Error: "groupView is null" {file:
"chrome://messenger/content/activity.js" line: 116}]'[JavaScript Error:
"groupView is null" {file: "chrome://messenger/content/activity.js" line:
116}]' when calling method: [nsIActivityMgrListener::onAddedActivity]"
nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"
location: "JS frame ::
file:///home/magnus/Code/tb/mozilla/obj-x86_64-pc-linux-gnu/dist/bin/
components/nsActivityManager.js :: addActivity :: line 65" data: yes]
2019-02-20 12:15:41 activitymgr ERROR addActivityBinding: TypeError:
groupView is nullThe patch looks basically ok. Perhaps there are just now problems because
the related elements aren't yet converted?
I will look into this now.
Updated•6 years ago
|
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Any suggestions on how to use static get inheritedAttributes() effectively?
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #8)
I think that is the correct way to use it.
LGTM, r=mkmelin
Do I need to add r=mkmelin in the commit message or will it be taken care at the time of check-in ?
Comment 10•6 years ago
|
||
Comment 11•6 years ago
|
||
The try run is good, the failures present are expected.
Assignee | ||
Comment 12•6 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #10)
Please add the super.connectedCallback() too here
It is showing an error that super.connectedCallback is not a function.
Comment 14•6 years ago
|
||
Comment 15•6 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/01b83ea83a23
De-XBL: convert activity-group to custom element. r=mkmelin DONTBUILD
Updated•6 years ago
|
Updated•5 years ago
|
Description
•