Closed Bug 1528250 Opened 6 years ago Closed 5 years ago

Remove right-click telemetry test from browser_UsageTelemetry_urlbar.js

Categories

(Firefox :: Address Bar, task, P3)

task
Points:
1

Tracking

()

RESOLVED FIXED
Iteration:
70.1 - Jul 8 - 21

People

(Reporter: standard8, Assigned: bugzilla)

References

Details

The existing URLBar has broken support for right click. It is stored as part of "FX_URLBAR_SELECTED_RESULT_METHOD" however:

  • If you enter a value, right-click the first/default result, press enter, it is recorded as "enter" (value 0).
  • If you enter a value, right-click on the second element, then:
    • The result is shown as selected
    • Pressing enter still selects the default result
    • It is recorded as a "rightClick" (value 5)
  • If you right-click and then use tab or arrow, the right-click will get overriden.

In QuantumBar, we've made it so that right-click never does anything - the selection isn't shown as changed, nor is it changed.

As a result, we can't easily handle telemetry with the existing behaviour. Therefore I think we should just drop right-click telemetry in its current form.

If we really want to continue tracking it, for the purposes of working out if we should try implementing something for it, I think we should instead do a simple measure of "the user right-clicked on the bar" regardless of what they did next.

If we don't implement anything for QuantumBar, we need to at least remove the relevant sub-test from browser_UsageTelemetry_urlbar.js.

It's fine to skip it and we can also remove it from the old code if that helps moving on.
The scope of this probe was to understand how many users were used to right click to select, and we collected enough data for that. Doesn't look like this case, as well as the tab case, are meaningful enough to block any kind of decision over them. The data shows a 0.00something%, even lower than the 0.3% using tab...

I also think it's ok to make right click do nothing for now and differ from the old urlbar.
In the future we'll evaluate whether to add a contextual menu or a hidden-by-default button with options for each result.

We'll need to annotate differences somewhere for QA,, I created a document here https://docs.google.com/document/d/1OCKJ25j8Y9ycwT1wdQWI2WeKpDzvqVBA4M2PgRnEp2k/edit#heading=h.dyk68s7hcdn we'll have to give them access to it.

Once we remove Awesomebar, we should remove the old test, updating dependencies.

Depends on: quantumbar
Summary: QuantumBar: right-click telemetry indication is hard to support → Remove right-click telemetry test from browser_UsageTelemetry_urlbar.js
Blocks: 1551227
No longer depends on: quantumbar
Type: defect → task
Points: --- → 1

The work on bug 1551233 removed this test.

Assignee: nobody → htwyford
Status: NEW → RESOLVED
Iteration: --- → 70.1 - Jul 8 - 21
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.