Closed Bug 1528453 Opened 6 years ago Closed 6 years ago

One-click search engine list in about:preferences has overlapping elements

Categories

(Firefox :: Settings UI, defect)

67 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 67
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- verified

People

(Reporter: ke5trel, Assigned: emilio)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attached image search-engine-overlap.png (deleted) —
Flags: needinfo?(emilio)
Assignee: nobody → emilio

Thanks for reporting this Kestrel :)

Flags: needinfo?(emilio)

In the regressing bug I accidentally removed a special-case for
min-{height/width}: 0 that treated it as auto for XUL trees:

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf8e35be76d8#l34.94

I can put it back if you think it's better, but these two lines of code were
here before min-width: auto even existed (min-width: 0 used to be the default).

I think this is better than changing the platform back to special-case
min-width: 0, and I don't see many other problematic uses of min-height /
min-width: 0, so let's try this.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47bcf8f29a21 Don't use min-height: 0 for xul trees. r=bgrins
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Confirmed the issue with 67.0a1 (20190215184035) on Windows 10 x64, Ubuntu 18.04 x64, macOS 10.13.6.
Fix verified with 67.0a1 (20190306095759), Windows 10 x64, Ubuntu 18.04 x64, macOS 10.13.6.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: