Closed Bug 1528494 Opened 6 years ago Closed 6 years ago

Perma /browser_as_render.js | Got the search handoff button - null == true - when Gecko 67 merges to beta on 2019-03-11

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 67
Iteration:
67.2 - Feb 11 - 24
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- fixed

People

(Reporter: NarcisB, Assigned: rrosario)

References

Details

(Keywords: github-merged, regression)

Attachments

(1 file)

Central as Beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=7cc2d6c073df873d0a8990f70eefbda1cf86ecc8&selectedJob=228835648

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228835648&repo=try&lineNumber=2510

Log snippet:

15:36:46 INFO - TEST-START | browser/components/newtab/test/browser/browser_as_render.js
15:36:46 INFO - TEST-INFO | started process screenshot
15:36:46 INFO - TEST-INFO | screenshot: exit 0
15:36:46 INFO - Buffered messages logged at 15:36:46
15:36:46 INFO - Entering test bound test_render_search
15:36:46 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_as_render.js | Got the search box - {} == true -
15:36:46 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_as_render.js | Search box is localized - "Search the Web" != "search_web_placeholder" -
15:36:46 INFO - Leaving test bound test_render_search
15:36:46 INFO - Entering test bound test_render_search_handoff
15:36:46 INFO - Buffered messages finished
15:36:46 INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_as_render.js | Got the search handoff button - null == true -
15:36:46 INFO - Stack trace:
15:36:46 INFO - resource://testing-common/content-task.js line 59 > eval:test_render_search_handoff:5
15:36:46 INFO - resource://testing-common/content-task.js:null:60
15:36:46 INFO - Leaving test bound test_render_search_handoff
15:36:46 INFO - Entering test bound test_render_topsites
15:36:47 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_as_render.js | Got the top sites section - {} == true -

:k88hudson , could this be caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1528410#c2 ?

Flags: needinfo?(khudson)
Flags: needinfo?(rrosario)

Yes, this is puzzling because I dont think there are any relevant differences between what is in Beta 66 and Nightly 67.

Flags: needinfo?(rrosario)

Looks like this was reported as intermittent before - Bug 1519829. So I guess something else changed that made it permanent. Probably a timing kind of issue? Are we waiting long enough for page to get rendered?

Oh right, and the code and pref are already on mozilla-beta, so I guess something must have changed recently for nightly 67 then.

The screenshot from test failure shows the -> arrow button, so it's showing the non-handoff version…

https://taskcluster-artifacts.net/F_U8PivvSmyZ8f22de412A/0/public/test_info/mozilla-test-fail-screenshot_r6qxjy.png

And curiously only fails on beta, so something with the pref being default false then switching to true.

Assignee: nobody → rrosario
Iteration: --- → 67.2 - Feb 11 - 24
Priority: -- → P1

This was caused by the patch for bug 1527702. Maybe should be uplifted together?

PR coming in a few.

Depends on: 1527702
Keywords: regression

This won't need to be uplifted to 66 beta for bug 1527702. This bug only affects 67.

Flags: needinfo?(khudson)
Keywords: github-merged
Blocks: 1529755
Target Milestone: --- → Firefox 67
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: