Closed
Bug 1528600
Opened 6 years ago
Closed 6 years ago
Change some global widget/cocoa functions to static
Categories
(Core :: Widget: Cocoa, enhancement, P3)
Core
Widget: Cocoa
Tracking
()
RESOLVED
FIXED
mozilla67
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
clang's -Wmissing-prototypes option can identify global functions that can be made static (because they are only called from one compilation unit) or removed (if they are never called).
|
Assignee | |
Comment 1•6 years ago
|
||
widget/cocoa/nsChildView.mm:1932:21 [-Wmissing-prototypes] no previous prototype for function 'TextureSizeForSize'
widget/cocoa/nsCocoaUtils.mm:351:6 [-Wmissing-prototypes] no previous prototype for function 'data_ss_release_callback'
|
|
Assignee | |
Comment 2•6 years ago
|
||
widget/cocoa/nsChildView.mm:249:6 [-Wmissing-prototypes] no previous prototype for function 'EnsureLogInitialized'
Depends on D20087
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/134db05991c2
widget/cocoa: Change some global functions to static. r=mstange
https://hg.mozilla.org/integration/autoland/rev/b255d130f718
widget/cocoa: Remove empty function EnsureLogInitialized(). r=mstange
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/134db05991c2
https://hg.mozilla.org/mozilla-central/rev/b255d130f718
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•