Improve the resolution of the GC_NURSERY_BYTES telemetry histogram
Categories
(Core :: JavaScript: GC, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: pbone, Assigned: pbone)
References
(Depends on 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/plain
|
pbone
:
data-review+
|
Details |
gfritzsche said that I need to make a new histogram.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9045485 [details] Data collection request Preliminary notes: If you're the one monitoring it, your individual email should be present in the list of alert_emails in the histogram definition (even if it is included in a mailing list that's also preset) to aid future discovery of the responsible person. I will move forward with the review assuming you'll go ahead and do that :) Also, you mention you wish to measure across populations but the histogram as written will not record on release channel. If you wish it to be recorded on all channels you'll need to add `"releaseChannelCollection": "opt-out"` to the histogram definition. You also should include as well an automated test that verifies that the probe doesn't break while we're not looking. I will proceed with the review assuming this is your intent. DATA COLLECTION REVIEW RESPONSE: Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. This collection is Telemetry so is documented in its definitions file ([Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json)), the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/), and on telemetry.mozilla.org's [Measurement Dashboards](https://telemetry.mozilla.org/new-pipeline/dist.html). Is there a control mechanism that allows the user to turn the data collection on and off? Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. If the request is for permanent data collection, is there someone who will monitor the data over time? Yes. Paul Bone is responsible. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 1, Technical. Is the data collection request for default-on or default-off? Default on for all channels. Does the instrumentation include the addition of any new identifiers? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? No. This collection is permanent. --- Result: datareview+, pending addition of release channel collection and automated test
|
|
Assignee | |
Comment 4•6 years ago
|
||
datareview+ carried forward.
Clarified to say that we don't want to collect data from the release channel.
Thanks.
|
|
Assignee | |
Comment 5•6 years ago
|
||
(In reply to Chris H-C :chutten from comment #3)
Comment on attachment 9045485 [details]
Data collection requestPreliminary notes:
If you're the one monitoring it, your individual email should be present in
the list of alert_emails in the histogram definition (even if it is included
in a mailing list that's also preset) to aid future discovery of the
responsible person. I will move forward with the review assuming you'll go
ahead and do that :)
Okay, I can do that. I suppose the whole team will monitor it, but in the shorter-term it'll be me who has the most interest.
Also, you mention you wish to measure across populations but the histogram
as written will not record on release channel. If you wish it to be recorded
on all channels you'll need to add"releaseChannelCollection": "opt-out"
to the histogram definition. You also should include as well an automated
test that verifies that the probe doesn't break while we're not looking. I
will proceed with the review assuming this is your intent.
Ah, I didn't mean to include release. I meant to choose "whatever's normal for our performance telemetry". I don't think we need release since we want to measure the impact of our changes to firefox.
DATA COLLECTION REVIEW RESPONSE:
Is the data collection request for default-on or default-off?Default on for all channels.
No, just nightly and beta.
Result: datareview+, pending addition of release channel collection and
automated test
Automated test?
|
|
Assignee | |
Comment 6•6 years ago
|
||
(In reply to Paul Bone [:pbone] from comment #5)
(In reply to Chris H-C :chutten from comment #3)
Result: datareview+, pending addition of release channel collection and
automated testAutomated test?
I can't find any testing code for GC_NURSERY_BYTES (the existing telemetry) at least in mozilla-central. I'm also not aware of any testing for other GC histograms. So I'll land this anyway and if that's an issue we should follow up with a bug to test all of the GC telemetry, however that's done.
|
|
Assignee | |
Updated•6 years ago
|
Pushed by pbone@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d25bc324f8fa Add a new version of the GC_NURSERY_BYTES telemetry histogram r=chutten
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
|
|
||
Comment 9•6 years ago
|
||
If a probe is renewed every 6 months then we check it every 6 months to make sure no one broke it. With permanent collection we don't have that cycle, so permanent collections benefit from automated tests.
The rest of GC telemetry predates the modern Data Collection Review where we list out requirements and best practices, so that might be why there's no tests to add to.
Description
•