Closed Bug 1529247 Opened 6 years ago Closed 6 years ago

Remove unused ThreadClient Methods

Categories

(DevTools :: Debugger, enhancement, P2)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yulia, Assigned: yulia)

References

Details

(Whiteboard: dt-fission)

Attachments

(8 files, 1 obsolete file)

Bug 1529247 - Remove environment method from the threadClient; r=ochameau
(deleted), text/x-phabricator-request
Details
Bug 1529247 - clean up frame scripts methods; r=ochameau
(deleted), text/x-phabricator-request
Details
Bug 1529247 - clean up frames methods on thread client; r=ochameau
(deleted), text/x-phabricator-request
Details
Bug 1529247 - remove unused getPrototypesAndProperties method; r=ochameau
(deleted), text/x-phabricator-request
Details
Bug 1529247 - remove unused cachedScript property; r=ochameau
(deleted), text/x-phabricator-request
Details
Bug 1529247 - remove unused releaseMany method from thread client and actor; r=ochameau
(deleted), text/x-phabricator-request
Details
Bug 1529247 - remove unused eventlisteners method; r=ochameau
(deleted), text/x-phabricator-request
Details
Bug 1529247 - remove unused pausedLongString method, threadLongString and arrayBuffer methods; r=ochameau
(deleted), text/x-phabricator-request
Details

There are a number of methods that are hold overs from the old debugger that should be cleaned up before we move towards transforming the ThreadClient into a protocol.js front.

these events no longer exist

Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8dc367557c04 clean up frame scripts methods; r=ochameau
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/49828e666e4d Remove environment method from the threadClient; r=ochameau
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/601742636bd1 remove unused getPrototypesAndProperties method; r=ochameau
Priority: -- → P2

There is one spot I am unsure about, and that is the test:
devtools/server/tests/unit/test_threadlifetime-06.js -- should this be kept or do we want to remove
it as well?

Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff07a2a59bb0 clean up frames methods on thread client; r=ochameau

Comment on attachment 9047709 [details]
Bug 1529247 - remove unused eval method from threadClient and threadActor; r=ochameau

Revision D21700 was moved to bug 1532567. Setting attachment 9047709 [details] to obsolete.

Attachment #9047709 - Attachment is obsolete: true
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eff76a5ca4f8 remove unused eventlisteners method; r=ochameau
Depends on: 1528986
No longer depends on: 1528986
Attachment #9047737 - Attachment description: Bug 1529247 - remove unused pausedLongString method and sustitute it with threadLongString method; r=ochameau → Bug 1529247 - remove unused pausedLongString method, threadLongString method and arrayBuffer method from threadclient; r=ochameau
Attachment #9047737 - Attachment description: Bug 1529247 - remove unused pausedLongString method, threadLongString method and arrayBuffer method from threadclient; r=ochameau → Bug 1529247 - remove unused pausedLongString method and sustitute it with threadLongString method; r=ochameau
Attachment #9047737 - Attachment description: Bug 1529247 - remove unused pausedLongString method and sustitute it with threadLongString method; r=ochameau → Bug 1529247 - remove unused pausedLongString method, threadLongString and arrayBuffer methods; r=ochameau
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05e9997b6809 remove unused pausedLongString method, threadLongString and arrayBuffer methods; r=ochameau

Is this done yulia?

Flags: needinfo?(ystartsev)

Looks like it is done -- I thought there was still some work to do on updatedSource but it looks like that was done already.

Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(ystartsev)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: