Closed Bug 1529305 Opened 6 years ago Closed 6 years ago

Add nasm in MinGW32/64 and the L10n for Windows 2012 opt 32/64

Categories

(Firefox Build System :: Toolchains, enhancement)

Product:
Firefox Build System
Component:
Toolchains
Version:
66 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox67 affected)

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- affected

People

(Reporter: achronop, Assigned: TD-Linux)

References

Details

Attachments

(2 files, 1 obsolete file)

Bug 1529305 - Add NASM env var to win64-plain/opt.
(deleted), text/x-phabricator-request
Details
Bug 1529305 - Emit cv8 debug info with nasm even on mingw.
(deleted), text/x-phabricator-request
Details

In order to enable ASM dav1d build on windows we are missing MinGW32/64 and the L10n for Windows 2012 opt 32/64 as described in [1].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1521062#c3

I think at least l10n should be fixed by a rebase.

In [1] is a latest try. I don't see a l10s build running at all. I haven't done anything differently. In any case if those runs have been removed only MinGW runs are the remaining failure.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad81a2977c43088285c812290cce5c099091b93b

Attached file Bug 1529305 - Fix mingw-gcc nasm target format. (obsolete) (deleted) —

This try run includes the patch in comment 3 on the top of the patches that enable ASM dav1d builds on windows from Bug 1521062.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d4698421d6a19067560bcb193d8005c46e12689

This one doesn't inherit the common mozconfig.nasm file.

Pushed by tdaede@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8ec03a6f1ca5 Add NASM env var to win64-plain/opt. r=dmajor
Attachment #9046551 - Attachment is obsolete: true

I made an alternate attachment. I had misunderstood mingw as using elf for .o, but it uses COFF, and nasm only supports cv8 debug info for that. I have no idea how the yasm manages to work, it's either stuffing dwarf in COFF or not being built at all for mingw.

Assignee: nobody → tdaede

https://hg.mozilla.org/mozilla-central/rev/8ec03a6f1ca5

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

There is a second patch in the queue that needs to be landed. We can close it then.

Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Pushed by tdaede@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/512b63ef9f71 Emit cv8 debug info with nasm even on mingw. r=firefox-build-system-reviewers,mshal

(In reply to Alex Chronopoulos [:achronop] from comment #10)

There is a second patch in the queue that needs to be landed. We can close it then.

Looks like both landed now, right? Can we resolve this?

Flags: needinfo?(tdaede)

Yeah, everything is there now, thank you very much.

Flags: needinfo?(tdaede)
Keywords: leave-open
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: