Closed Bug 1529336 Opened 6 years ago Closed 2 years ago

OS.File loads scripts in a way that means they stick around in memory as strings

Categories

(Toolkit Graveyard :: OS.File, defect, P3)

Tracking

(firefox67 affected)

RESOLVED WONTFIX
Tracking Status
firefox67 --- affected

People

(Reporter: Gijs, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxperf:p3])

about:memory shows 5 strings with total length around 90-100k and thus taking around 200k of memory (yay ucs2 + js overhead, I guess).

This is in addition to the actual interpreted/compiled representations.

We should try to avoid this. It's probably a consequence of the use of require.js - perhaps now we can "just" use es6 modules or some other, better mechanism.

Whiteboard: [fxperf]

It might also be the DOM holding one copy of the string and JS holding another copy.

(In reply to David Teller [:Yoric] (please use "needinfo") from comment #1)

It might also be the DOM holding one copy of the string and JS holding another copy.

Sorry, what exactly do you mean? Workers don't have a DOM, right?

Flags: needinfo?(dteller)

They don't have access to the document but they have access to some DOM APIs.

Here, it's XHR used in a worker.

Flags: needinfo?(dteller)

Marking as P3 because it seems only related to memory usage. However, if someone proposes a solution that would also improve the load times for OS.File, we would probably bump the priority.

Whiteboard: [fxperf] → [fxperf:p3]

I thought that memory usage was back to being a priority?

Flags: needinfo?(gijskruitbosch+bugs)
Priority: -- → P3

(In reply to David Teller [:Yoric] (please use "needinfo") from comment #5)

I thought that memory usage was back to being a priority?

We're focused on startup time and mainthread IO for the moment.

Flags: needinfo?(gijskruitbosch+bugs)

This will be solved when we remove OS.File

Depends on: 1776480
Severity: normal → S3

OS.File is being removed.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.