Closed Bug 1529355 Opened 6 years ago Closed 4 years ago

emit unwinding directives for aarch64 in dump_syms

Categories

(Toolkit :: Crash Reporting, enhancement)

ARM64
All
enhancement
Not set
normal

Tracking

()

RESOLVED MOVED

People

(Reporter: froydnj, Assigned: froydnj)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1517739 +++

+++ This bug was initially created as a clone of Bug #1513284 +++

See discussion in bug 1517739, which is almost, but not quite, the same thing.

aarch64 windows uses a custom unwind information format to describe
how to unwind from within functions. We need to parse that
information to describe to Breakpad how to unwind stacks for minidump
analysis.

Thanks for this, I'll review it tomorrow first thing. Since these changes happen into the part of Breakpad we haven't forked of it would be nice to push them upstream but I'm OK with landing them first directly in mozilla-central because we need them ASAP.

Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b171bfdb308f
emit STACK CFI lines for aarch64 windows; r=gsvelto

Works on my machine, but I guess that's not sufficient proof. Will also fix up the assertion errors...

Flags: needinfo?(nfroyd)

Nathan, do you have time to finish this? I can take over it (and push it upstream) if you're too busy.

Flags: needinfo?(nfroyd)

(In reply to Gabriele Svelto [:gsvelto] from comment #6)

Nathan, do you have time to finish this? I can take over it (and push it upstream) if you're too busy.

I do have time to finish this; the problem I ran into was that clang (and, presumably, Rust) emit bogus unwind information for some functions, which causes dump_syms to wander off into the weeds. I haven't had time to dive into LLVM yet, though the bug I filed (https://bugs.llvm.org/show_bug.cgi?id=40876) sounds like it might not be too hard to fix.

Flags: needinfo?(nfroyd)

I see, we're hitting all sort of corner cases lately with debuginfo :-/

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → MOVED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: