Closed Bug 1529394 Opened 6 years ago Closed 6 years ago

pref on the incognito feature

Categories

(WebExtensions :: General, enhancement, P1)

enhancement

Tracking

(firefox65 unaffected, firefox66 unaffected, firefox67+ verified)

VERIFIED FIXED
mozilla67
Tracking Status
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 + verified

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

(Blocks 2 open bugs)

Details

Attachments

(4 files)

Might be a touch more than just a pref update, have to run all tests through to ensure any that use private windows continue to work.

This patch addresses remaining test issues when pref'ing on. These are tests that
previously ran some tests in private contexts that now require the use of incognitoOverride.
This also fixes an xpcshell test wrapper to set the permission when overridden.

Pushed by scaraveo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3a8c338af709 fix tests for pref'ing on incognito not_allowed r=rpl https://hg.mozilla.org/integration/autoland/rev/7f3e254c982c pref 'on' incognito not_allowed r=kmag

Tracking for 67, this will probably require an addition to our release notes.

Pushed by scaraveo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f4cf036e591 fix tests for pref'ing on incognito not_allowed r=rpl
Blocks: 1532774
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Two more patches to land.

Status: RESOLVED → REOPENED
Flags: needinfo?(mixedpuppy)
Resolution: FIXED → ---
Pushed by scaraveo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/53ac343019c6 revert early breakout to support test infra extensions r=rpl https://hg.mozilla.org/integration/autoland/rev/095dde8fb209 pref 'on' incognito not_allowed r=kmag
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Attached image Bug1529394.gif (deleted) —

The preference “extensions.allowPrivateBrowsingByDefault” is set to false by default.

With the preference set to false by default, the extensions need to be allowed to work in private windows.

Please see the attached video.

This issue is verified as fixed on Firefox 67.0a1 (20190306161300) under Win 7 64-bit and Mac OS X 10.14.1.

Status: RESOLVED → VERIFIED
Regressions: 1541827
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: