pref on the incognito feature
Categories
(WebExtensions :: General, enhancement, P1)
Tracking
(firefox65 unaffected, firefox66 unaffected, firefox67+ verified)
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | unaffected |
| firefox66 | --- | unaffected |
| firefox67 | + | verified |
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
(Blocks 2 open bugs)
Details
Attachments
(4 files)
Bug1529394.gif
Might be a touch more than just a pref update, have to run all tests through to ensure any that use private windows continue to work.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
This patch addresses remaining test issues when pref'ing on. These are tests that
previously ran some tests in private contexts that now require the use of incognitoOverride.
This also fixes an xpcshell test wrapper to set the permission when overridden.
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
|
Assignee | |
Comment 5•6 years ago
|
||
|
|
Assignee | |
Comment 6•6 years ago
|
||
|
|
Assignee | |
Comment 7•6 years ago
|
||
|
|
Assignee | |
Comment 8•6 years ago
|
||
|
|
Assignee | |
Comment 9•6 years ago
|
||
|
|
Assignee | |
Comment 10•6 years ago
|
||
|
|
Assignee | |
Comment 11•6 years ago
|
||
|
||
Comment 12•6 years ago
|
||
|
||
Comment 13•6 years ago
|
||
Backed out for failing bc at automation.py
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=231749685&repo=autoland&lineNumber=2230
Backout: https://hg.mozilla.org/integration/autoland/rev/f324b0fe247192d8f1a3cad23b84e2e16a56249c
|
|
Assignee | |
Comment 14•6 years ago
|
||
|
|
Assignee | |
Comment 15•6 years ago
|
||
|
||
Comment 16•6 years ago
|
||
Tracking for 67, this will probably require an addition to our release notes.
|
|
||
Comment 17•6 years ago
|
||
|
|
Assignee | |
Comment 18•6 years ago
|
||
|
|
Assignee | |
Comment 19•6 years ago
|
||
|
||
Comment 20•6 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 21•6 years ago
|
||
Two more patches to land.
|
||
Updated•6 years ago
|
|
|
||
Comment 22•6 years ago
|
||
|
||
Comment 23•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/53ac343019c6
https://hg.mozilla.org/mozilla-central/rev/095dde8fb209
|
||
Comment 24•6 years ago
|
||
The preference “extensions.allowPrivateBrowsingByDefault” is set to false by default.
With the preference set to false by default, the extensions need to be allowed to work in private windows.
Please see the attached video.
|
|
||
Comment 25•6 years ago
|
||
This issue is verified as fixed on Firefox 67.0a1 (20190306161300) under Win 7 64-bit and Mac OS X 10.14.1.
Description
•