Closed
Bug 1529656
Opened 6 years ago
Closed 6 years ago
Add -Wl,-plugin when -Wl,-plugin-opt is specified
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: mshal, Assigned: mshal)
References
Details
Attachments
(1 obsolete file)
Bug 1520149 added a -Wl,-plugin-opt flag, but that fails on a PGO-instrumented android build with:
/builds/worker/workspace/build/src/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: fatal error: --plugin-opt requires --plugin.
Adding -Wl,-plugin to the flags as the error message suggests seems to fix it.
|
Assignee | |
Comment 1•6 years ago
|
||
The -Wl,-plugin-opt flag introduced in bug 1520149 conflicts with
PGO-instrumented code generation for Android, unless -Wl,-plugin is also
specified.
|
||
Updated•6 years ago
|
Attachment #9045706 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 2•6 years ago
|
||
As glandium mentioned in phabricator, disabling LTO in the mozconfig fixes the issue here, so this patch isn't needed.
|
|
Assignee | |
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•