clang-format extension erroring on Windows
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Tracking
(firefox-esr60 unaffected, firefox65 unaffected, firefox66 unaffected, firefox67 fixed)
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox65 | --- | unaffected |
firefox66 | --- | unaffected |
firefox67 | --- | fixed |
People
(Reporter: davejustishh, Assigned: andi)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Errors when running hg commit
with clang-format extension enabled on Windows 10
Dave Justice@LAPTOP-NA0Q0G86 /c/mozilla-build/mozilla-central
$ hg commit
Processing 5 file(s)...
Process PoolWorker-1:
Traceback (most recent call last):
File "c:\mozilla-build\python\lib\multiprocessing\process.py", line 267, in _bootstrap
self.run()
File "c:\mozilla-build\python\lib\multiprocessing\process.py", line 114, in run
self._target(*self._args, **self._kwargs)
File "c:\mozilla-build\python\lib\multiprocessing\pool.py", line 102, in worker
Process PoolWorker-2:
Traceback (most recent call last):
File "c:\mozilla-build\python\lib\multiprocessing\process.py", line 267, in _bootstrap
task = get()
File "c:\mozilla-build\python\lib\multiprocessing\queues.py", line 376, in get
self.run()
return recv()
File "c:\mozilla-build\python\lib\multiprocessing\process.py", line 114, in run
I self._target(*self._args, **self._kwargs)
mportError: No module named 4b8aac71360011e98d4600e18ca3ea22
P rocess PoolWorker-3:
File "c:\mozilla-build\python\lib\multiprocessing\pool.py", line 102, in worker
Traceback (most recent call last):
task = get()
File "c:\mozilla-build\python\lib\multiprocessing\process.py", line 267, in _bootstrap
File "c:\mozilla-build\python\lib\multiprocessing\queues.py", line 376, in get
self.run()
File "c:\mozilla-build\python\lib\multiprocessing\process.py", line 114, in run
self._target(*self._args, **self._kwargs)
File "c:\mozilla-build\python\lib\multiprocessing\pool.py", line 102, in worker
return recv()
I task = get()
mportError: No module named 4b8aac71360011e98d4600e18ca3ea22
File "c:\mozilla-build\python\lib\multiprocessing\queues.py", line 376, in get
return recv()
ImportError: No module named 4b8aac71360011e98d4600e18ca3ea22
Reporter | ||
Comment 1•6 years ago
|
||
A little more context for this:
I had gotten my repo up to date with latest from upstream and had about 3 local commits that I used hg strip
to get rid of before committing my changes which triggered this error.
Comment 2•6 years ago
|
||
Andi will have a look as I don't know much about windows
Comment 3•6 years ago
|
||
Bug 1529415 looks related, maybe a duplicate/unrelated to the clang-format
hg extension itself.
Comment 6•6 years ago
|
||
Andi, if this is too complex, we could just disable parallel execution on windows until we have a fix.
Assignee | ||
Comment 7•6 years ago
|
||
- A sheriff is going to revert b59977d42a4d
- I will redo this after we have the backout using
futures
sincemultiprocessing
is broken on windows.
Aryx, Dluca, can you please backout changeset b59977d42a4d?
Comment 8•6 years ago
|
||
Changeset b59977d42a4d has been reverted here : https://hg.mozilla.org/mozilla-central/rev/121bbaec1b30e7e0a4cf1b9db1db2bd8898306e6
Updated•6 years ago
|
Assignee | ||
Comment 9•6 years ago
|
||
Parts of this patch were taken from the original work of :bbouvier in Bug 1521772.
We needed to revert Bug 1521772 since it broken Windows compatibility.
Updated•6 years ago
|
Comment 10•6 years ago
|
||
bugherder |
Comment 11•6 years ago
|
||
Updated•6 years ago
|
Updated•2 years ago
|
Description
•