Open Bug 1529916 Opened 6 years ago Updated 2 years ago

use ObjectClient.release instead of DebuggerClient.release in reps

Categories

(DevTools :: Debugger, task, P3)

task

Tracking

(Fission Milestone:Future)

Fission Milestone Future

People

(Reporter: yulia, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: dt-fission-future)

While switching all client to fronts, we will no longer manipulate actor IDs and instead always call requests through their front instance.

Debugger

For the debugger it appears to exclusively be used from reps: https://searchfox.org/mozilla-central/search?q=releaseActor&case=false&regexp=false&path=debugger

reps

reps usage of release is limited to the objectInspector:

https://searchfox.org/mozilla-central/source/devtools/client/debugger/new/packages/devtools-reps/src/object-inspector/actions.js#100-105

We set actors in two locations:

https://searchfox.org/mozilla-central/source/devtools/client/debugger/new/packages/devtools-reps/src/object-inspector/reducer.js#38-47,53-65

If we trace the NODE_PROPERTIES_LOADED event to where it is being set as the actor value, we come to this point:

We are operating on rdpGrips: https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/devtools/client/debugger/new/packages/devtools-reps/src/object-inspector/utils/node.js#54-68

It is called, for example, from nodeExpand: https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/devtools/client/shared/components/reps/reps.js#7026

Which sets its actor from this function: https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/devtools/client/shared/components/reps/reps.js#2969-2973

This is fortunately the only usage of getActor in the devtools-reps codebase. https://searchfox.org/mozilla-central/search?q=getActor(&case=false&regexp=false&path=devtools-reps

We can just replace it with getValue

For the GETTER_INVOKED event, it is easier, we just need to pass the object client from here:

https://searchfox.org/mozilla-central/source/devtools/client/debugger/new/packages/devtools-reps/src/object-inspector/actions.js#107-131

It looks like we are not even setting the actor id string there.

Priority: -- → P2
Type: enhancement → task
Priority: P2 → P3
Whiteboard: dt-fission → dt-fission-reserve
Depends on: 1588997

dt-fission-reserve bugs do not need to block Fission Nightly (M6).

Tracking dt-fission-reserve bugs for Fission MVP until we know whether they really need to block Fission or not.

Fission Milestone: --- → MVP

Moving old "dt-fission-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.

Fission Milestone: MVP → Future
Whiteboard: dt-fission-reserve → dt-fission-future
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.