use ObjectClient.release instead of DebuggerClient.release in reps
Categories
(DevTools :: Debugger, task, P3)
Tracking
(Fission Milestone:Future)
Fission Milestone | Future |
People
(Reporter: yulia, Unassigned)
References
(Blocks 2 open bugs)
Details
(Whiteboard: dt-fission-future)
While switching all client to fronts, we will no longer manipulate actor IDs and instead always call requests through their front instance.
Debugger
For the debugger it appears to exclusively be used from reps: https://searchfox.org/mozilla-central/search?q=releaseActor&case=false®exp=false&path=debugger
reps
reps usage of release is limited to the objectInspector:
We set actors in two locations:
If we trace the NODE_PROPERTIES_LOADED event to where it is being set as the actor value, we come to this point:
We are operating on rdpGrips: https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/devtools/client/debugger/new/packages/devtools-reps/src/object-inspector/utils/node.js#54-68
It is called, for example, from nodeExpand: https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/devtools/client/shared/components/reps/reps.js#7026
Which sets its actor from this function: https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/devtools/client/shared/components/reps/reps.js#2969-2973
This is fortunately the only usage of getActor in the devtools-reps codebase. https://searchfox.org/mozilla-central/search?q=getActor(&case=false®exp=false&path=devtools-reps
We can just replace it with getValue
For the GETTER_INVOKED event, it is easier, we just need to pass the object client from here:
It looks like we are not even setting the actor id string there.
Updated•6 years ago
|
Updated•6 years ago
|
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 1•5 years ago
|
||
dt-fission-reserve bugs do not need to block Fission Nightly (M6).
Comment 2•4 years ago
|
||
Tracking dt-fission-reserve bugs for Fission MVP until we know whether they really need to block Fission or not.
Comment 3•4 years ago
|
||
Moving old "dt-fission-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.
Updated•2 years ago
|
Description
•