Closed Bug 1529917 Opened 6 years ago Closed 5 years ago

Remove VariablesViewController

Categories

(DevTools :: Shared Components, task, P1)

task

Tracking

(firefox73 fixed)

RESOLVED FIXED
Firefox 73
Tracking Status
firefox73 --- fixed

People

(Reporter: yulia, Assigned: nchevobbe)

References

(Blocks 2 open bugs)

Details

(Whiteboard: dt-fission-m1)

Attachments

(1 file)

While switching all client to fronts, we will no longer manipulate actor IDs and instead always call requests through their front instance.

Scratchpad

Scratchpad seems to use it exclusively from the variablesview: https://searchfox.org/mozilla-central/search?q=releaseActor&case=false&regexp=false&path=scratchpad

VariableView

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/devtools/client/shared/widgets/VariablesViewController.jsm#573

Like in other places, it appears that this collection only exists in order to release the actors.

Depends on: 1519103
Priority: -- → P3
Whiteboard: dt-fission → dt-fission-reserve
Component: Scratchpad → Shared Components

I'm not sure I follow this bug correctly, but it looks like it is still relevant as the storage panel is still using the VariableView
and there is still a releaseActor method in it:
https://searchfox.org/mozilla-central/source/devtools/client/shared/widgets/VariablesViewController.jsm#727-738

VariablesViewController doesn't look to be used anywhere now, so I'm going to remove it and repurpose this bug to do so, since the VariablesView does not call any release function (and Scratchpad was removed).

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Type: enhancement → task
Summary: Use release method from actor instead of DebuggerClient.release in VariableView → Remove VariablesViewController

It isn't used anywhere, so we can safely remove it.

Priority: P3 → P1
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9301bdb66fb4 Remove VariablesViewController.jsm. r=miker.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5f8829083bfc Remove VariablesViewController.jsm. r=miker.

Backed out 2 changesets (Bug 1529917, Bug 1591874) for causing bustages in VariablesView.jsm

Backout link: https://hg.mozilla.org/integration/autoland/rev/4cf52729f132bf19c9465044d4f0e14b9cca25de

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=598800&tochange=4cf52729f132bf19c9465044d4f0e14b9cca25de&fromchange=0b5282256e0094eeae41d6c6377c6b37893cbf06&selectedJob=279319506

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279319506&repo=autoland&lineNumber=1390

[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - mozbuild.frontend.reader.SandboxValidationError:
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - ==============================
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - FATAL ERROR PROCESSING MOZBUILD FILE
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - ==============================
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - The error occurred while processing the following file or one of the files it includes:
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - /builds/worker/workspace/build/src/devtools/client/storage/moz.build
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - The error occurred when validating the result of the execution. The reported error is:
[task 2019-12-03T13:23:07.427Z] 13:23:07 INFO - File listed in FINAL_TARGET_FILES does not exist: /builds/worker/workspace/build/src/devtools/client/storage/VariablesView.jsm

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9fbb57c24aa0 Remove VariablesViewController.jsm. r=miker.
Backout by malexandru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fffe8ae5c5d2 Backed out 2 changesets (bug 1529917, bug 1591874) for causing build bustages in VariablesView.jsm CLOSED TREE
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f6b30c89d279 Remove VariablesViewController.jsm. r=miker.

There was an issue with Lando (see Bug 1600990).

Flags: needinfo?(nchevobbe)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
Whiteboard: dt-fission-reserve → dt-fission
Whiteboard: dt-fission → dt-fission dt-fission-m1
Whiteboard: dt-fission dt-fission-m1 → dt-fission-m1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: