Closed Bug 1529979 Opened 6 years ago Closed 2 years ago

ContentSearchChild.jsm should cache information

Categories

(Firefox :: Search, enhancement, P3)

enhancement

Tracking

()

RESOLVED WONTFIX

People

(Reporter: Felipe, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [fxperf:p3])

ContentSearch.jsm is already nice enough to broadcast information to ContentSearchChild any time there are changes to the state (the state being the list of search engines and which is the default one).

However, ContentSearchChild doesn't do any effort to keep this information cached locally, and requests this information again every time a new about:newtab tab is open.

Given that this cached information is kept in the privileged content process, and that process is kept alive [1], this is even more incentive to keep the information cached in the child. It would avoid an expensive msg round-trip for every new tab open.

[1] https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/modules/libpref/init/all.js#3379

Whiteboard: [fxperf] → [fxperf:p3]

If I understand this correctly, then I think this is probably either a matter of caching the CurrentState and CurrentEngine messages in ContentSearchChild.jsm.

Unless there's a way to cache the ContentSearchUIController._engines and ContentSearchUIController._defaultEngine values in contentSearchUI.js.

Priority: -- → P3

I think once bug 1704156 is fixed, this will no longer be necessary.

Severity: normal → N/A
Depends on: 1704156

Closing as a WONTFIX because it is highly likely that we'll remove the in-content search box code.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.