Update libc crate to 0.2.51
Categories
(Core :: General, enhancement)
Tracking
()
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
0.2.49 has a some fixes for FreeBSD on non-x86. Let's update.
https://github.com/rust-lang/libc/pull/1221
https://github.com/rust-lang/libc/pull/1222
https://github.com/rust-lang/libc/pull/1236
(Sorry, I can't upload on Phabricator due to MFA policy which is incompatible with GitHub login)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a18c91a5c7125b51bd0a24376f7e7c0e4a4b353f
Fails no Windows aarch64. Is this a known issue?
14:12:02 INFO - LLVM ERROR: SEH unwind data splitting not yet implemented
14:12:02 ERROR - error: Could not compile style
.
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=230082805&repo=try&lineNumber=20252-20253
We dealt with this issue before for C++, but this is the first time it's come up in Rust. It sounds like rustc's copy of LLVM will need to merge https://bugs.llvm.org/show_bug.cgi?id=40311.
Though I'm kind of surprised that rustc is doing SEH stuff on aarch64-windows, as that too was only recently implemented in LLVM, not long before the bugfix above. What revision of LLVM does rustc use? I wonder if there are more patches from around that time that they'd want to merge.
Comment 5•6 years ago
|
||
Updated•6 years ago
|
Comment 7•6 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jbeich, could you have a look please?
Rebased and bumped to 0.2.51 (current latest). Keeping r+ from comment 5.
I was waiting on bug 1530448 but also had and still have an issue with pushing to Try e.g.,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=25a054100f1a57385b8971b45c2425f92ae869b3
but separate optimized/debug build seem to work
https://treeherder.mozilla.org/#/jobs?repo=try&revision=80e17d93173416f531a1b3f530639bad7a83ab52
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdf5d1d54a2828bcf6366a6c5bd121333ef5b265
Comment 9•6 years ago
|
||
Jan, I've received hunk failed while applying this patch:
"applying bug1530098.diff
patching file Cargo.lock
Hunk #1 FAILED at 73
Hunk #7 succeeded at 859 with fuzz 1 (offset 0 lines).
Hunk #9 FAILED at 939
Hunk #28 succeeded at 2396 with fuzz 2 (offset 0 lines).
Hunk #36 succeeded at 3316 with fuzz 2 (offset 0 lines).
2 out of 39 hunks FAILED -- saving rejects to file Cargo.lock.rej"
Can you please take a look?
Assignee | ||
Comment 10•6 years ago
|
||
Rebase after bug 1529117 hit mozilla-central.
Comment 11•6 years ago
|
||
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40052223c3a2
Update libc crate to 0.2.51 to pick up FreeBSD fixes for non-x86. r=froydnj
Comment 12•6 years ago
|
||
bugherder |
Updated•6 years ago
|
Description
•