Closed Bug 1530507 Opened 6 years ago Closed 6 years ago

Make sure plugin code is stubbed out for arm64 builds

Categories

(Core Graveyard :: Plug-ins, enhancement)

Product:
Core Graveyard
Component:
Plug-ins
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox67+ fixed, firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox67 + fixed
firefox68 --- fixed

People

(Reporter: jimm, Assigned: jimm)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

patch
(deleted), patch
Details | Diff | Splinter Review
Bug 1530507 - Make sure plugin code is stubbed out for arm64 builds. r=bobowen
(deleted), text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details

Look over plugin code and make sure plugins can't be instantiated on arm64.

Attached patch patch (deleted) — — Splinter Review
Assignee: nobody → jmathies

This seems very low-risk to uplift for

Blocks: aarch64-windows-67-uplift
Pushed by jmathies@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/85712605b11a Make sure plugin code is stubbed out for arm64 builds. r=bobowen

https://hg.mozilla.org/mozilla-central/rev/85712605b11a

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

(In reply to Chuck Harmston [:chuck] from comment #3)

This seems very low-risk to uplift for

Tracking as you intend to uplift to 67 and it landed in 68. Note that we can start nominating uplifts for beta 4 that ships end of this week.

tracking-firefox67: --- → +

Comment on attachment 9050669 [details]
Bug 1530507 - Make sure plugin code is stubbed out for arm64 builds. r=bobowen

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: None
  • User impact if declined: differences in plugin handling behavior
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1530507
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): prefs change that disables our plugin code
  • String changes made/needed: none
  • Do you want to request approval of these patches as well?: on
Attachment #9050669 - Flags: approval-mozilla-beta?

Comment on attachment 9050669 [details]
Bug 1530507 - Make sure plugin code is stubbed out for arm64 builds. r=bobowen

Low risk uplift for arm64 plugins compatibility, approved for 67 beta 4.

Attachment #9050669 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Blocks: 1538785
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: