Closed
Bug 1530507
Opened 6 years ago
Closed 6 years ago
Make sure plugin code is stubbed out for arm64 builds
Categories
(Core Graveyard :: Plug-ins, enhancement)
Core Graveyard
Plug-ins
Tracking
(firefox67+ fixed, firefox68 fixed)
RESOLVED
FIXED
mozilla68
People
(Reporter: jimm, Assigned: jimm)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
Look over plugin code and make sure plugins can't be instantiated on arm64.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee: nobody → jmathies
Assignee | ||
Comment 2•6 years ago
|
||
Pushed by jmathies@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85712605b11a
Make sure plugin code is stubbed out for arm64 builds. r=bobowen
Comment 5•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Comment 6•6 years ago
|
||
(In reply to Chuck Harmston [:chuck] from comment #3)
This seems very low-risk to uplift for
Tracking as you intend to uplift to 67 and it landed in 68. Note that we can start nominating uplifts for beta 4 that ships end of this week.
tracking-firefox67:
--- → +
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 9050669 [details]
Bug 1530507 - Make sure plugin code is stubbed out for arm64 builds. r=bobowen
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: None
- User impact if declined: differences in plugin handling behavior
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1530507
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): prefs change that disables our plugin code
- String changes made/needed: none
- Do you want to request approval of these patches as well?: on
Attachment #9050669 -
Flags: approval-mozilla-beta?
Comment 8•6 years ago
|
||
Comment on attachment 9050669 [details]
Bug 1530507 - Make sure plugin code is stubbed out for arm64 builds. r=bobowen
Low risk uplift for arm64 plugins compatibility, approved for 67 beta 4.
Attachment #9050669 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•6 years ago
|
||
bugherder uplift |
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•