Implement FormDataEvent interface
Categories
(Core :: DOM: Events, enhancement, P2)
Tracking
()
People
(Reporter: marcosc, Assigned: jdai)
References
()
Details
(Keywords: parity-chrome)
Attachments
(2 obsolete files)
Part of HTML.
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 1•6 years ago
|
||
Hi Anne, Olli,, I noticed we don't currently implement the FormDataEvent interface (it's in Chrome only it seems).
Seems really straight forward to add so happy to quickly implement it.
Do you know of any reason/controversy why we haven't implemented it yet? If you think it's worth while, I'll be happy to do it (Overholt permitting, of course).
Reporter | ||
Comment 2•6 years ago
|
||
Sorry, I mean hsinyi permitting (as triage owner), not overholt.
Reporter | ||
Updated•6 years ago
|
Comment 3•6 years ago
|
||
Chatted with hsinyi, please go ahead! Though note that before enabling this by default we should really fix all of bug 1518442, including dispatching the formdata event on <form> elements, including when they're used in the FormData constructor and such.
Reporter | ||
Comment 4•6 years ago
|
||
Sounds like a plan. I’ll try to do the Event behind a pref this week and investigate the form dispatching in the other bug.
Reporter | ||
Updated•6 years ago
|
Comment 5•6 years ago
|
||
Thanks Marcos for taking this. :)
Comment 6•6 years ago
|
||
Thanks.
(and reason was, no one had spare time :) )
Updated•6 years ago
|
Comment 7•6 years ago
|
||
We don't have this at all on MDN; compat data will need writing too.
Reporter | ||
Comment 8•6 years ago
|
||
Scaffolding for FormDataEvent.
Updated•6 years ago
|
Reporter | ||
Comment 9•6 years ago
|
||
Generate FormDataEvent and onformdata
Reporter | ||
Comment 10•6 years ago
|
||
Olli, quick question: the FormDataEvent needs to bubble, but the generated event doesn't bubble by default. If there some way to tell the binding generator to let the event bubble? or do I need need to copy out the generated code and set it manually?
Comment 11•6 years ago
|
||
You set the bubbling flag when actually dispatching the event. The interface or its implementation doesn't do anything magical on that matter.
Reporter | ||
Comment 12•6 years ago
|
||
Ah, of course. I got confused.
Comment 13•6 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:marcosc, could you have a look please?
Comment 14•6 years ago
|
||
This is not supposed to land before bug 1518442.
(and of course the discussion about that is in phabricator :/)
Assignee | ||
Comment 15•5 years ago
|
||
I implemented it on bug 1518442 part 1, so close this bug.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Description
•