Closed Bug 1530591 Opened 6 years ago Closed 5 years ago

Implement FormDataEvent interface

Categories

(Core :: DOM: Events, enhancement, P2)

enhancement

Tracking

()

RESOLVED DUPLICATE of bug 1518442

People

(Reporter: marcosc, Assigned: jdai)

References

()

Details

(Keywords: parity-chrome)

Attachments

(2 obsolete files)

Part of HTML.

Hi Anne, Olli,, I noticed we don't currently implement the FormDataEvent interface (it's in Chrome only it seems).

Seems really straight forward to add so happy to quickly implement it.

Do you know of any reason/controversy why we haven't implemented it yet? If you think it's worth while, I'll be happy to do it (Overholt permitting, of course).

Flags: needinfo?(bugs)
Flags: needinfo?(annevk)

Sorry, I mean hsinyi permitting (as triage owner), not overholt.

Keywords: parity-chrome

Chatted with hsinyi, please go ahead! Though note that before enabling this by default we should really fix all of bug 1518442, including dispatching the formdata event on <form> elements, including when they're used in the FormData constructor and such.

Blocks: 1518442
Flags: needinfo?(bugs)
Flags: needinfo?(annevk)

Sounds like a plan. I’ll try to do the Event behind a pref this week and investigate the form dispatching in the other bug.

Assignee: nobody → mcaceres

Thanks Marcos for taking this. :)

Thanks.
(and reason was, no one had spare time :) )

Priority: -- → P2

We don't have this at all on MDN; compat data will need writing too.

Keywords: dev-doc-needed
Attached file Bug 1530591 - Implement FormDataEvent interface (obsolete) (deleted) —

Scaffolding for FormDataEvent.

Attachment #9047306 - Attachment is obsolete: true
Attached file Bug 1530591 Implement FormDataEvent interface (obsolete) (deleted) —

Generate FormDataEvent and onformdata

Olli, quick question: the FormDataEvent needs to bubble, but the generated event doesn't bubble by default. If there some way to tell the binding generator to let the event bubble? or do I need need to copy out the generated code and set it manually?

Flags: needinfo?(bugs)

You set the bubbling flag when actually dispatching the event. The interface or its implementation doesn't do anything magical on that matter.

Flags: needinfo?(bugs)

Ah, of course. I got confused.

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:marcosc, could you have a look please?

Flags: needinfo?(mcaceres)

This is not supposed to land before bug 1518442.
(and of course the discussion about that is in phabricator :/)

Flags: needinfo?(mcaceres)

I implemented it on bug 1518442 part 1, so close this bug.

Assignee: mcaceres → jdai
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Resolution: FIXED → DUPLICATE
Attachment #9049178 - Attachment is obsolete: true
No longer blocks: 1518442
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: