QuantumBar should notify WebExtension's WebNavigation of transition data
Categories
(WebExtensions :: General, enhancement, P2)
Tracking
(firefox68 fixed)
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
For the existing address bar, WebNavigation.jsm listens to autocomplete-did-enter-text to get details about transition types for tabs/history.
We need to port the code to work with QuantumBar - and ensure we get browser/components/extensions/test/browser/browser_ext_webNavigation_urlbar_transitions.js passing.
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
The WIP patch is just to port the test to UrlbarTestUtils and hopefully it should run. I'm not sure if it'll need more work once the main patch is fixed.
I'm not planning on working on this in the short term.
|
||
Comment 3•6 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #2)
The WIP patch is just to port the test to UrlbarTestUtils and hopefully it should run. I'm not sure if it'll need more work once the main patch is fixed.
I'm not planning on working on this in the short term.
Given this, would it be OK to P5 this to get it off our triage? I don't want to close it prematurely, but I also don't want to track it if it's going to be addressed by something else.
|
|
Assignee | |
Comment 4•6 years ago
|
||
From a QuantumBar point of view this is probably a P2. I suspect one of us will be fixing it fairly soon as we're getting to the end of QuantumBar issues.
|
|
Assignee | |
Comment 5•6 years ago
|
||
Having said that, I'm now in a position that I'm going to work on it.
|
|
||
Updated•6 years ago
|
|
||
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
|
||
Comment 8•6 years ago
|
||
Can you please provide some STR for this issue so we can check it manually? If no manual testing is needed please mark it as "qe-verify- "
|
|
Assignee | |
Comment 9•6 years ago
|
||
This has good test coverage that's working both pre and post QuantumBar, so I don't think we need additional testing here.
Description
•