Closed Bug 1530900 Opened 6 years ago Closed 5 years ago

Format conversion happening during texture upload on Mac because of TexStorage

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: jrmuizel, Assigned: kvark)

References

(Blocks 1 open bug)

Details

We spend an appreciable amount of time in glgConvertTo_32<GLGConverter_ABGR8_ARGB8, (GLGMemory)1>(GLGOperationRec const*, GLDPixelModeRec const*)

We can do better.

Blocks: wr-67

So based on other related functions it looks like that function is converting from ABGR8 to ARGB8. It's not clear what the byte order of those format specifications is though. That being said, I'm confused as to why it thinks we have ABGR8.

The call to TexSubImage3D that calls glgConvertTo_32<GLGConverter_ABGR8_ARGB8, (GLGMemory)1> has format = GL_BGRA and type = GL_UNSIGNED_BYTE

I think our problem is forcing Apple to use RGBA8 as the internal format of textures.

It turns out this is caused by using TexStorage3D on mac.

Summary: Format conversion happening during texture upload on Mac → Format conversion happening during texture upload on Mac because of TexStorage
Blocks: wr-68
No longer blocks: wr-67
Blocks: wr-70
No longer blocks: wr-68
Blocks: wr-mac
No longer blocks: wr-70
Assignee: nobody → dmalyshau
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.