Support the edit context menu on html textareas in top level windows in the parent process
Categories
(Toolkit :: General, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(2 files, 1 obsolete file)
The basic problem here is that context menus for textareas inside a <browser> are handled by nsContextMenu.js, and context menus for XUL textboxes are handled from the <moz-input-box> element. But they don't currently work for plain HTML input fields.
I'm spinning a fix for this out of Bug 1513343.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
|
||
Comment 2•6 years ago
|
||
|
||
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
|
|
||
Comment 3•6 years ago
|
||
TV fails TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_edit_contextmenu.html | paste enabled (https://treeherder.mozilla.org/#/jobs?repo=try&revision=b85728bb296c3e1c83517d75ba86a5105782be04&selectedJob=231705567). It runs locally just fine. I suppose that some tests running before this one has to copy something into clipboard, what makes this test fail. Would it be reasonable to remove that line from the test?
|
|
||
Updated•6 years ago
|
|
|
||
Comment 4•6 years ago
|
||
(In reply to alexander :surkov (:asurkov) from comment #3)
TV fails TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_edit_contextmenu.html | paste enabled (https://treeherder.mozilla.org/#/jobs?repo=try&revision=b85728bb296c3e1c83517d75ba86a5105782be04&selectedJob=231705567). It runs locally just fine. I suppose that some tests running before this one has to copy something into clipboard, what makes this test fail. Would it be reasonable to remove that line from the test?
I guess I will disable paste_enabled test for landing to not to hold the whole thing down, and leave it to Brian whether it should be enabled or not. It feels ok to skip it since it looks it is browser state dependent.
|
||
Comment 6•6 years ago
|
||
You could just stick something on the clipboard beforehand if needed using SimpleTest.promiseClipboardChange. You'd need to move the test into the clipboard subsuite as well.
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
|
||
Comment 8•6 years ago
|
||
Shouldn't this have removed https://searchfox.org/mozilla-central/rev/89414a1df52d06cfc35529afb9a5a8542a6e4270/browser/base/content/test/static/browser_all_files_referenced.js#684 ?
|
|
Assignee | |
Comment 9•6 years ago
|
||
|
|
Assignee | |
Comment 10•6 years ago
|
||
(In reply to :Gijs (he/him) from comment #8)
Shouldn't this have removed https://searchfox.org/mozilla-central/rev/89414a1df52d06cfc35529afb9a5a8542a6e4270/browser/base/content/test/static/browser_all_files_referenced.js#684 ?
Checked with https://treeherder.mozilla.org/#/jobs?repo=try&revision=52b66c9ec05854ffd23deb998ffbaff5b881b66a and it seems so, thanks.
|
||
Comment 11•6 years ago
|
||
|
||
Comment 12•6 years ago
|
||
| bugherder | ||
Description
•