Closed Bug 1531350 Opened 6 years ago Closed 6 years ago

Update Debugger Frontend v128

Categories

(DevTools :: Debugger, enhancement, P2)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(2 files, 2 obsolete files)

128-1.patch
(deleted), patch
Details | Diff | Splinter Review
Bug 1531350 - Add column breakpoints (w/ fix for sourcemaps-reload). r=me
(deleted), text/x-phabricator-request
Details
Attached patch 128-1.patch (deleted) — — Splinter Review
Assignee: nobody → jlaster
Attachment #9047542 - Flags: data-review?(dwalsh)
Attachment #9047542 - Flags: data-review?(dwalsh)
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/235a7abcdb08 [release] use webpack manifest. r=dwalsh https://hg.mozilla.org/integration/mozilla-inbound/rev/db37efddbcb6 [release 128] Sync 128. r=dwalsh https://hg.mozilla.org/integration/mozilla-inbound/rev/58001e734b33 [release 128] Fix reps launchpad (#8015). r=dwalsh https://hg.mozilla.org/integration/mozilla-inbound/rev/7961797a2f82 [release 128] Update snapshots for SourcesTreeItem (#8016). r=dwalsh https://hg.mozilla.org/integration/mozilla-inbound/rev/e8d1d5e6f541 [release 128] [Breakpoints] Fix color for disabled conditional breakpoints and logpoints (#8008). r=dwalsh https://hg.mozilla.org/integration/mozilla-inbound/rev/fc8c00c6ebaf [release 128] Update name of repository (#8018). r=dwalsh https://hg.mozilla.org/integration/mozilla-inbound/rev/f3bc0a57e1f6 [release 128] [Breakpoints] getBreakpointPositionsForLine should return null when nothing is found (#8006). r=dwalsh https://hg.mozilla.org/integration/mozilla-inbound/rev/b68f9ac11c4f [release 128] [Breakpoints] Use the union of all mapped and unmapped regions when fetching original breakpoints. (#8014). r=dwalsh https://hg.mozilla.org/integration/mozilla-inbound/rev/0291de30d958 [release 128] Update debugging-the-debugger.md (#8021). r=dwalsh https://hg.mozilla.org/integration/mozilla-inbound/rev/2856ab932b13 [release 128] Add a BigInt rep. (#7975). r=dwalsh https://hg.mozilla.org/integration/mozilla-inbound/rev/9560b0da49d4 [release 128] [Breakpoints] memoize breakpoint position fetching (#8001). r=dwalsh https://hg.mozilla.org/integration/mozilla-inbound/rev/b6811a8e2c6e [release 128] [ast] Migrate AST reducer off of immutable (#7982). r=dwalsh https://hg.mozilla.org/integration/mozilla-inbound/rev/50a280e9bdff Update debugger frontend Release 128. r=dwalsh

I believe the windowless-workers errors are for an existing intermittent

https://bugzilla.mozilla.org/show_bug.cgi?id=1531612

Attachment #9047544 - Attachment is obsolete: true
Pushed by lsmyth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dd4c4ce4a78d [release 128] [Breakpoints] use the selected location for column breakpoints.
Backout by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b452fad68dc3 Backed out changeset dd4c4ce4a78d for debugger failure CLOSED TREE
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/295288a58683 Revert "Backed out changeset dd4c4ce4a78d for debugger failure CLOSED TREE"

Backed out changeset 295288a58683 (bug 1531350) for failing at /browser_dbg-sourcemaps-reload.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/2c2584c8276f00c69f24e2a3353aaf642c144f05

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=os%2Cx%2C10.10%2Cdebug%2Cmochitests%2Cwith%2Ce10s%2Ctest-macosx64%2Fdebug-mochitest-devtools-chrome-e10s-5%2Cm-e10s%28dt5%29&fromchange=fb3cbe9457a98eddda6488517d6a70ce3ab64a16&selectedJob=232090639

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232090639&repo=autoland&lineNumber=21020

Log snippet:

07:59:09 INFO - Waiting for ADD_BREAKPOINT to dispatch 1 time(s)
07:59:09 INFO - ADD_BREAKPOINT dispatched 1 time(s)
07:59:09 INFO - TEST-PASS | devtools/client/debugger/new/test/mochitest/browser_dbg-sourcemaps-reload.js | a new breakpoint was created -
07:59:09 INFO - TEST-PASS | devtools/client/debugger/new/test/mochitest/browser_dbg-sourcemaps-reload.js | undefined assertion name -
07:59:09 INFO - Reload with a new version of the file
07:59:09 INFO - Waiting for SYNC_BREAKPOINT to dispatch 1 time(s)
07:59:09 INFO - Navigating to doc-sourcemaps-reload2.html
07:59:09 INFO - Waiting for NAVIGATE to dispatch 1 time(s)
07:59:09 INFO - NAVIGATE dispatched 1 time(s)
07:59:09 INFO - Waiting on sources: v1.js
07:59:09 INFO - Waiting for state change: source v1.js exists
07:59:09 INFO - Buffered messages logged at 23:59:08
07:59:09 INFO - Finished waiting for state change: source v1.js exists
07:59:09 INFO - Finished waiting on sources: v1.js
07:59:09 INFO - Buffered messages logged at 23:59:09
07:59:09 INFO - SYNC_BREAKPOINT dispatched 1 time(s)
07:59:09 INFO - Buffered messages finished
07:59:09 INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/new/test/mochitest/browser_dbg-sourcemaps-reload.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/debugger/new/test/mochitest/browser_dbg-sourcemaps-reload.js:43 - TypeError: breakpoint is undefined
07:59:09 INFO - Stack trace:
07:59:09 INFO - @chrome://mochitests/content/browser/devtools/client/debugger/new/test/mochitest/browser_dbg-sourcemaps-reload.js:43:3
07:59:09 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1106:34
07:59:09 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1134:12
07:59:09 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:995:14
07:59:09 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
07:59:09 INFO - Leaving test bound

Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e9364ffb92a6 Add column breakpoints (w/ fix for sourcemaps-reload). r=loganfsmyth
Attachment #9047973 - Attachment is obsolete: true
Blocks: 1533767
Flags: needinfo?(jlaster)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: