Closed Bug 1531707 Opened 6 years ago Closed 5 years ago

Empty attachment check shouldn't open channel synchronously

Categories

(Thunderbird :: Mail Window Front End, enhancement)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: neil, Unassigned)

References

Details

In bug 489406 code was added to open attachments synchronously to see whether their size is zero. As dmose pointed out in bug 489406 comment #10:

some of our streams will be blocking, so this could cause the UI to freeze. Making this code use callbacks or async streams is going to make it harder to read.

It may be harder to read, but we really shouldn't be opening channels synchronously.

This is fixed in a pending patch for Bug 1345167, using fetch().

Depends on: 1345167
Depends on: 489406
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → Trunk

Fixed in Bug 1345167.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.