Closed Bug 1532511 Opened 6 years ago Closed 6 years ago

Changes: UI polish for button hover/active states

Categories

(DevTools :: Inspector: Changes, defect, P3)

defect

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: victoria, Assigned: rcaliman)

References

Details

Attachments

(1 file)

After I used the buttons in Nightly for a while, I realized the light mode colors that I specified before seemed too intense. (Sorry about this!)

I tested out new between-states that are one step lighter, and I think this fits into the rest of DevTools much better. This also involves making the normal/hover color the same for the Copy Rule buttons because the double hover effect seemed distracting. The Invision mockup has been updated to reflect these new colors.

Just for fun, here's the test code for light mode (with opaque hex values that you probably don't want + more examples of the background: ; bug) :)


.changes__copy-all-changes-button:hover {
  background: ;
  background-color: #F3F3F3;
}

.changes__copy-rule-button:hover {
  /* background-color: var(--changes-button-copy-rule-background-color--hover); */
}

.changes__copy-rule-button {
  /* background-blend-mode: overlay; */
  /* background-color: var(--changes-button-copy-rule-background-color); */
  /* background-image: linear-gradient(var(--theme-sidebar-background), var(--theme-sidebar-background)); */
  background-color: #F3F3F3;
}

.changes__copy-all-changes-button:active {
  background: ;
  background-color: #E6E6E6;
}

.changes__copy-rule-button:active {
  /* background-color: #tile-search > a:nth-child(1) > span:nth-child(1) \{ align-content: center; */
  background-color: #e6e6e6;
}```
Assignee: nobody → rcaliman
Blocks: 1515875
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a649b71a797e Update colors for buttons in Changes panel; r=pbro
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: