Add profiler markers for long-running GL calls
Categories
(Core :: Graphics: WebRender, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
text/x-phabricator-request
|
Details |
CPU time spent in GL calls is not always the most important indicator of performance, but it's certainly one important dimension. In bug 1531183, we have a GL driver that won't let us unwind the stack to get profiler samples, leaving us guessing as to what the samples correspond to.
Instead of jumping through hoops to solve that problem, we can simply feed this information to the profiler directly via markers when the call runs longer than a given threshold. We can do this only when the thread is actively being profiled to avoid any risk of slowing down WebRender in the wild.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
Depends on D22200
|
|
Assignee | |
Comment 3•6 years ago
|
||
Depends on D22201
|
||
Updated•6 years ago
|
|
||
Comment 6•6 years ago
|
||
Backed out 3 changesets (Bug 1532810) for wrench bustages CLOSED TREE
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232709020&repo=mozilla-inbound&lineNumber=237
|
|
Assignee | |
Comment 8•6 years ago
|
||
|
|
||
Updated•6 years ago
|
|
||
Comment 10•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8426cec31aae
https://hg.mozilla.org/mozilla-central/rev/1972b8836948
Description
•