[Affected versions]:
Nightly 67.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.14, and Ubuntu 16.04 x64.

[Preconditions]:
In about:config set:

• devtools.aboutdebugging.network -> true
• devtools.aboutdebugging.new-enabled -> true

[Steps to reproduce]:

1. Launch Firefox and go to "about:debugging" after you set all the preconditions or go to "about:debugging-new" without the need to set preconditions.
2. Click on "This Firefox" tab.
   From "Tabs" section, click on "Inspect" button for any of the open tabs.
3. Click on "Performance" tab.
4. Click on "Start Recording Performance".

[ Expected result]:
Performance recording visual progress should be displayed.

[Actual result]:
Performance recording visual progress isn't displayed.

[Note]:
It's not reproducible when the toolbox is displayed in a new tab.

It seems all the charts of the Performance tab are not working when displayed in about:devtools-toolbox. Even after you finish recording the profile, there is just a blank area on top of the table.

Tested the part of "Performance" on Mac OS X - In about:devtools-toolbox ->after a performance test is performed, on the 3rd option, "JS Flame Chart" - no info's are displayed. See the latest screenshot attached

This is blocking ongoing work for fission, taking the bug.

Depends on D26900
Fixes the blank chart and load issues for the old perf panel in about:devtools-toolbox (or type=content)

Depends on D26919

This test also needs the fixes from Bug 1538731

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=655f0618ebc68092f6c070b265e05dbfaadd7bdb

Backed out for failing dt at browser_perf-range-changed-render.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=239656526&revision=f7050f15a28dbe22ef9f0f73a9778db0da794fbe

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239656526&repo=autoland&lineNumber=3956

Backout: https://hg.mozilla.org/integration/autoland/rev/54e502f0f78edfe26fc4faa080dcd9ea5f6047a8

Same comment as on the other bug, this test is already intermittent.

The test became perma-failure starting with your push

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=8428f4ba4a51304584ade9bcbbcb2d555807b406&searchStr=devtools&selectedJob=239656526 - bug 1472186

Added some logs on try, it seems that during this test an extra rendering of the WaterfallView is triggered by a "resize" event fired by its MarkerDetails widget. MarkerDetails can fire resize for 3 reasons:

• click on splitter
• calling the hidden setter
• window resize

This "resize" event seems to be fired when the JsFlameGraph is rendered. This FlameGraph relies on the Graphs.js file modified in my patch. A new try push is ongoing to determine which one of them is responsible for the extra event. Possible explanation would be that using DOMHelpers to load the FlameGraph is slightly slower than the previous approach and might trigger a window resize.

If that's the case, I think it would be valid valid to accept both 4 or 3 renderings of WaterfallView.

new try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0de1a68231bab9e26fe5b772c426cb82a919520

Try confirms that a window resize is responsible for the extra rendering here.

Depends on D26920

See Bug 1532993#c12 for the analysis. The extra rendering is due to a window resize that
seems to always happen on ASAN but not on other platforms.

green try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e2d7de89c92e78aa0c0003dab2f9bc952af6ad5

https://hg.mozilla.org/mozilla-central/rev/7bd34721fb35
https://hg.mozilla.org/mozilla-central/rev/5e86cf625b54
https://hg.mozilla.org/mozilla-central/rev/fc8e9758009c

Julian, this is a P1 and the patch doesn't look big, do you want to request uplift to beta or do you think it is better to let it ride the trains? Thanks

It can ride the trains, it is mostly relevant for the new remote debugging which will be enabled only in 68. Thanks!

Thanks, adjusting flags.

Verified as fixed on Firefox Nightly 68.0a1 (2019-04-17) on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 16.04 x64.