Remove dependency from palette-v7 in GeckoView
Categories
(GeckoView :: General, enhancement, P2)
Tracking
(firefox87 fixed)
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: agi, Assigned: agi, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [geckoview:m88])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We probably don't need this dependency and causes a lot of headaches to people that use different versions of the support library.
:nalexander says that this might only be used in Fennec.
|
Assignee | |
Updated•6 years ago
|
|
||
Comment 1•6 years ago
|
||
P2 if this causes problems for other developers using GV, not a high priority unless it impacts Fenix or FFTV.
|
||
Comment 2•5 years ago
|
||
We don't use this dependency for Fennec, but for GV we use it in BitmapUtils, which we use to get the dominant colour for Themes. We can remove for Fennec, no problems, but if this is an issue should we find another method for getting the dominant colour for GV or just leave it in?
|
|
Assignee | |
Comment 3•5 years ago
|
||
I think the idea would be to find another way to do that (e.g. we could just port that little piece of code inside GV if it's workable).
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•4 years ago
|
||
Looks like BitmapUtils is basically not unused anymore.
|
|
Assignee | |
Comment 5•4 years ago
|
||
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
Description
•