Lint Debugger on try
Categories
(DevTools :: Debugger, enhancement, P3)
Tracking
(firefox67 fixed)
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
We should run yarn lint in the try test so that our JS, CSS, and MD is linted.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5d5db39b0497 Lint Debugger on try. r=davidwalsh
Comment 3•6 years ago
|
||
Backed out for debugger failures
backout: https://hg.mozilla.org/integration/autoland/rev/c84fd846abe142b628e1c8bcd2144c7c4f21983c
failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=232744085&repo=autoland
[task 2019-03-08T20:21:28.787Z]
[task 2019-03-08T20:21:28.787Z] Oops! Something went wrong! :(
[task 2019-03-08T20:21:28.788Z]
[task 2019-03-08T20:21:28.788Z] ESLint: 5.9.0.
[task 2019-03-08T20:21:28.788Z] ESLint couldn't find the plugin "eslint-plugin-no-unsanitized". This can happen for a couple different reasons:
[task 2019-03-08T20:21:28.788Z]
[task 2019-03-08T20:21:28.788Z] 1. If ESLint is installed globally, then make sure eslint-plugin-no-unsanitized is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
[task 2019-03-08T20:21:28.788Z]
[task 2019-03-08T20:21:28.788Z] 2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
[task 2019-03-08T20:21:28.789Z]
[task 2019-03-08T20:21:28.789Z] npm i eslint-plugin-no-unsanitized@latest --save-dev
[task 2019-03-08T20:21:28.789Z]
[task 2019-03-08T20:21:28.789Z] Path to ESLint package: /builds/worker/checkouts/gecko/devtools/client/debugger/new/node_modules/eslint
[task 2019-03-08T20:21:28.789Z]
[task 2019-03-08T20:21:28.789Z] If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.
[task 2019-03-08T20:21:28.789Z]
[task 2019-03-08T20:21:28.855Z] error Command failed with exit code 2.
[task 2019-03-08T20:21:28.855Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[task 2019-03-08T20:21:28.911Z] error Command failed with signal "SIGTERM".
[task 2019-03-08T20:21:28.911Z] error Command failed with signal "SIGTERM".
[task 2019-03-08T20:21:28.911Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[task 2019-03-08T20:21:28.911Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[task 2019-03-08T20:21:28.921Z] error Command failed with signal "SIGTERM".
[task 2019-03-08T20:21:28.921Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[task 2019-03-08T20:21:29.278Z] ERROR: "lint:js" exited with 1.
[task 2019-03-08T20:21:29.283Z] error Command failed with exit code 1.
[task 2019-03-08T20:21:29.283Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[taskcluster 2019-03-08 20:21:29.936Z] === Task Finished ===
[taskcluster 2019-03-08 20:21:29.936Z] Unsuccessful task run with exit code: 1 completed in 713.376 seconds
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/423f48c98230 Lint Debugger on try. r=davidwalsh
Comment 6•6 years ago
|
||
Backed out for failing try test
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233113900&repo=autoland&lineNumber=373
Backout: https://hg.mozilla.org/integration/autoland/rev/ee2473319e97f98373b68151353b4de5e2cfc2c3
Updated•6 years ago
|
Comment 7•6 years ago
|
||
Hm, I can't reproduce this locally. This is probably the tests fault rather than the change. Maybe we should disable the test while I try to figure this out.
I'll run a few try pushes to see if I can reproduce.
Comment 8•6 years ago
|
||
I think the test is intermittent (if you look at jlast's push there were two passes and two failures) and is likely unrelated to his changes. This test only runs when specific files are modified, which might explain why this failure hasn't shown up before.
I'm looking into why it's intermittent now. Obviously a 50% pass rate isn't acceptable so I'm fine if we disable the test in the meantime.
Comment 10•6 years ago
|
||
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/68834c8b15bd Lint Debugger on try. r=davidwalsh
Comment 11•6 years ago
|
||
I've confirmed that this test fails on vanilla mozilla-central as well, so please don't backout the above push if it happens again. I think I have a handle on the problem over in bug 1534375.
Comment 12•6 years ago
|
||
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ded300544a9 Lint Debugger on try.
Comment 13•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/68834c8b15bd
https://hg.mozilla.org/mozilla-central/rev/6ded300544a9
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Description
•