Malloc contention on WrWorker threads is too high.
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: nical)
References
(Blocks 1 open bug)
Details
(Whiteboard: [wr-q2][wr-april])
Attachments
(3 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
This shows up when profiling https://static.mozilla.com/moco/en-US/images/mozilla_eoy_2013_EN.svg
|
Assignee | |
Comment 1•6 years ago
|
||
Things to try:
- Opt into per-worker-thread arena with jemalloc.
- Lower the thread count from
num-cpustonum-cpus - 1with a maximum of maybe 6 or 8. We get diminishing returns from having many threads due to this contention issue and the per-thread overhead of a few things like managing fonts. - Recycle the tile pixels.
|
|
Assignee | |
Updated•6 years ago
|
|
Reporter | |
Comment 2•6 years ago
|
||
|
|
Reporter | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
||
Updated•6 years ago
|
|
||
Comment 6•6 years ago
|
||
Backed out for build bustages at build/src/gfx/webrender_bindings/WebRenderAPI.cpp
Push that started the failures:https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=d0260a2dac6c070d654e858965b82b4eb06b0d76&selectedJob=242277680
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242277680&repo=mozilla-inbound&lineNumber=18487
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/968d4ed2e984a65bfb8bd60a9820c4aa45624dd5
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ed474f3cbc38
https://hg.mozilla.org/mozilla-central/rev/1edf22da902a
https://hg.mozilla.org/mozilla-central/rev/4615f45cd4fe
|
||
Comment 10•6 years ago
|
||
wait, wasnt all these changes backed out in comment 8, and not relanded?
(In reply to Raul Gurzau (:RaulGurzau) from comment #9)
https://hg.mozilla.org/mozilla-central/rev/ed474f3cbc38
https://hg.mozilla.org/mozilla-central/rev/1edf22da902a
https://hg.mozilla.org/mozilla-central/rev/4615f45cd4fe
Isnt the third change the backout of the other two?
|
|
Assignee | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
|
||
Comment 11•6 years ago
|
||
|
|
Assignee | |
Comment 12•6 years ago
|
||
Isnt the third change the backout of the other two?
I had (confusingly) only backed out one of the two commits.
|
||
Comment 13•6 years ago
|
||
| bugherder | ||
|
||
Comment 14•6 years ago
|
||
Big perf improvements noticed! \0/
== Change summary for alert #20681 (as of Sun, 28 Apr 2019 05:19:44 GMT) ==
Improvements:
25% tsvg_static linux64-shippable-qr opt e10s stylo 59.99 -> 45.28
12% tsvgx linux64-shippable-qr opt e10s stylo 281.98 -> 248.04
10% tsvg_static windows10-64-shippable-qr opt e10s stylo 40.93 -> 36.67
8% tsvgr_opacity linux64-shippable-qr opt e10s stylo 103.70 -> 95.52
6% tsvgx windows10-64-shippable-qr opt e10s stylo 194.91 -> 183.11
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=20681
Description
•