Repeated messages break autoscroll to bottom
Categories
(DevTools :: Console, defect, P1)
Tracking
(firefox-esr60 unaffected, firefox65 unaffected, firefox66+ verified, firefox67 verified)
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox65 | --- | unaffected |
| firefox66 | + | verified |
| firefox67 | --- | verified |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta-
lizzard
:
approval-mozilla-release+
|
Details |
This affects 66, not 65.
Running a mozregression to find the changes that introduced the regression
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 2•6 years ago
|
||
When a message was repeated, the bubble would appear and
slightly increase the message size (by 1px), making it
lose its bottom-anchoring. Then, if a new message came,
the console won't automatically scroll anymore.
This patch modifies the repeat bubble CSS so it doesn't
impact the message height, and add a test case in the
test which asserts the scroll to bottom feature.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e6970424c0ef Fix scroll to bottom with repeated messages; r=Honza.
|
||
Comment 4•6 years ago
|
||
:nchevobbe, does it affect 67 ?
|
|
Assignee | |
Comment 5•6 years ago
|
||
yes it does
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
How common do you think is this for users to run into?
Can the fix wait for 67 or are you looking to uplift to 66?
|
|
Assignee | |
Comment 8•6 years ago
|
||
I want to request an uplift on this. I ran into it, and someone using webpack development server too, which I guess is widely spread. The actual fix is a one line CSS change, so I'm confident about the uplift being safe.
|
|
Assignee | |
Comment 9•6 years ago
|
||
Comment on attachment 9049465 [details]
Bug 1533667 - Fix scroll to bottom with repeated messages; r=Honza.
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: Bug 1486870
- User impact if declined: When a message is repeated in the console, it won't automatically scroll to the bottom, which is essential for console users
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: 1. Go to https://nchevobbe.github.io/demo/console-test-app.html
- Open the console
- In the page, click the
infobutton until the console output overflows - In the page, click the
Log repeatable messagebutton twice - Click the
infobutton a few more time
-> The console should still be scrolled to the bottom.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): One line CSS change (removing a margin) in DevTools + automated test
- String changes made/needed:
Comment on attachment 9049465 [details]
Bug 1533667 - Fix scroll to bottom with repeated messages; r=Honza.
CSS fix for regression in 66. OK for uplift to m-r.
|
||
Comment 11•6 years ago
|
||
| bugherder uplift | ||
|
||
Updated•6 years ago
|
|
||
Updated•6 years ago
|
|
||
Comment 12•5 years ago
|
||
Confirmed the issue with Firefox 66.0b14.
Fix verified with 66_RC and 67.0a1 (2019-03-11) on Windows 10, macOS 10.12, Ubuntu16.04.
Description
•