Closed Bug 1533949 Opened 6 years ago Closed 5 years ago

[Fission] Make BrowserChild ready for Fission

Categories

(Toolkit :: General, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Fission Milestone M3
Tracking Status
firefox69 --- fixed

People

(Reporter: Felipe, Assigned: mconley)

References

Details

Attachments

(2 files, 1 obsolete file)

Make the code in BrowserChild.jsm ready to work with out-of-process iframes

Priority: -- → P3
Fission Milestone: --- → M2

Hey jdai, I have a patch up here that'll port one of our old-school actors to JS Window Actors, but I've realized that that's not going to be a full Fission-compatible port in this case.

BrowserParent / BrowserChild are responsible for determining whether or not a tab can be unloaded, or if a page is blocking that unload via the beforeunload event.

For multiple frames across multiple processes, I think we're going to need a way of broadcasting a message to all of the subframes, and then getting a result from each.

Is that broadcast capability planned?

Flags: needinfo?(jdai)

hey, the patch is missing the BrowserParent.jsm file!

fwiw, the browsingContext in the parent side has a getChildren() function that can be used to enumerate all children BCs* and then use them to call .getActor().. At least, that was the original plan for broadcasting.. I don't know if some built-in functionality is also planned.

  • note that one call to getChildren is not enough.. it requires tree traversal as the items returned could themselves have children.

Since :Felipe already answered your question, I'm going to cancel the needinfo request. Feel free to open a bug, if you need any functionality. I'm willing to help. :)

Flags: needinfo?(jdai)
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Fission Milestone: M2 → M3
Depends on: 1549753
Attachment #9056734 - Attachment is obsolete: true
Attachment #9064177 - Attachment description: Bug 1533949 - Make BrowserChild actor Fission-compatible. r?NeilDeakin → Bug 1533949 - Make BrowserChild functions Fission-compatible, and move to BrowserElementChild. r?NeilDeakin
Depends on: 1550613
Depends on: 1523638
Depends on: 1552186
No longer depends on: 1523638
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d6ba0372205 Make nsIRemoteTab.hasBeforeUnload check each OOP subframe as well. r=rhunt https://hg.mozilla.org/integration/autoland/rev/574775878141 Make BrowserChild functions Fission-compatible, and move to BrowserElementChild. r=NeilDeakin
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: