Merge Phablicator Revisions with Attachments
Categories
(bugzilla.mozilla.org :: User Interface, enhancement)
Tracking
()
People
(Reporter: kohei, Unassigned)
References
(Depends on 1 open bug)
Details
Attachments
(2 files, 2 obsolete files)
Since :dkl has added the Phablicator Revisions to the modal UI modules, Phablicator attachments are displayed redundantly on the bug page. Let’s “KonMari” the clutter.
Comment 1•6 years ago
|
||
mcote and I had planned to do this so I will take this.
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Merged to master.
Reporter | ||
Comment 4•6 years ago
|
||
Looks like we have to back this out. I’ve just realized that if Phablicator requests are hidden from the attachment list, the details link will be gone and uplift requests cannot be made. Maybe we should rather merge the Phabricator Revisions module into the Attachments module.
Reporter | ||
Comment 5•6 years ago
|
||
Well, the details link is still displayed inline, but you need to scroll down to find it.
Reporter | ||
Comment 6•6 years ago
|
||
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Is this still needed?
Reporter | ||
Comment 8•5 years ago
|
||
I think so. 1 Phablicator request doesn’t matter, but sometimes there are 5+ requests like Bug 1519434, and the redundant Phablicator Revisions and Attachments sections waste a large portion of the page. This can be WONTFIX :dkl’s original PR works if uplift requests will be done directly on Phablicator, otherwise the Details link is still needed as I said earlier in Comment 4.
Comment 9•5 years ago
|
||
Updated•2 years ago
|
Description
•