The about:support fluent migration (bug 1507595) caused a "Missing translations in en-US" error
Categories
(Toolkit :: General, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox65 | --- | unaffected |
firefox66 | --- | wontfix |
firefox67 | --- | fixed |
People
(Reporter: Kwan, Assigned: Gijs)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
During one of the patch updates [0] in bug 1507595 an inexplicable change [1] slipped in that started trying to translate a function value explicitly annotated as not for translating. Most of the time it skips actually trying since usually the value is an array (of nodes) and it explicitly ignores arrays. But sometimes it's a plain text string which it'll try and treat as a fluent ID. When this is a long complex string like
wheel input enabled; scrollbar drag enabled; keyboard enabled; autoscroll enabled
it'll fail since toFluentID()
will reject it, but when it's the simple none
it'll try and retrieve a fluent string with the id "none" and log a missing strings error.
(Note: I haven't been able to reproduce this after writing up this bug, it's possible some since-hg shelve
ed local changes to about:support were affecting timings in a way that caused it to manifest, but filing since the code still seems seems bogus anyway)
[0] https://phabricator.services.mozilla.com/D14905?vs=45908&id=46920#inline-80951
just below this comment, look for "Not localized"
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
(In reply to Ian Moody [:Kwan] (UTC+0) from comment #0)
During one of the patch updates [0] in bug 1507595 an inexplicable change [1] slipped in that started trying to translate a function value explicitly annotated as not for translating.
This was a result of now actually passing localizable values; the mistake was not updating the comment. E.g.:
A lot of callers (to addRow
) are now passing [new Text("some string")]
for exactly this reason.
And, confusingly, I think the "none" case you're looking at is https://searchfox.org/mozilla-central/source/toolkit/content/aboutSupport.js#451 , which already has a fluent ID, so it can just pass that...
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 4•6 years ago
|
||
bugherder |
Updated•6 years ago
|
Description
•