Closed Bug 1534799 Opened 6 years ago Closed 3 years ago

Convert &searchTextBox.clear.label; to fluent and use manual DOM construction

Categories

(Toolkit :: General, enhancement, P3)

Product:
Toolkit
Component:
General
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: ntim, Assigned: niklas)

References

Details

Attachments

(1 file)

Bug 1534799 - Convert &searchTextBox.clear.label; to fluent. r?emalysz!
(deleted), text/x-phabricator-request
Details

See the comment linking to this bug in toolkit/content/widgets/search-textbox.js

Priority: -- → P3
Assignee: nobody → nbaumgardner
Attachment #9237978 - Attachment description: WIP: Bug 1534799 - Convert &searchTextBox.clear.label; to fluent. r?emalysz → Bug 1534799 - Convert &searchTextBox.clear.label; to fluent. r?emalysz
Attachment #9237978 - Attachment description: Bug 1534799 - Convert &searchTextBox.clear.label; to fluent. r?emalysz → Bug 1534799 - Convert &searchTextBox.clear.label; to fluent. r?emalysz!
Blocks: 1726341
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f42e32addd89 Convert &searchTextBox.clear.label; to fluent. r=emalysz,fluent-reviewers,flod,dao,morgan

Backed out for causing failures on test_txtctrl.xhtml

[task 2021-09-08T15:30:15.924Z] 15:30:15     INFO - TEST-PASS | accessible/tests/mochitest/tree/test_txtctrl.xhtml | Wrong previous sibling of ['img node', address: [object HTMLImageElement], role: graphic, name: 'Clear', address: 0x7fef0c92a0b0] 
[task 2021-09-08T15:30:15.924Z] 15:30:15     INFO - Buffered messages finished
[task 2021-09-08T15:30:15.926Z] 15:30:15     INFO - TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/tree/test_txtctrl.xhtml | Wrong value of property 'role' for ['img node', address: [object HTMLImageElement], role: graphic, name: 'Clear', address: 0x7fef0c92a0b0].got 'graphic', expected 'pushbutton' 
[task 2021-09-08T15:30:15.926Z] 15:30:15     INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:417:16
[task 2021-09-08T15:30:15.926Z] 15:30:15     INFO - isRole@chrome://mochitests/content/a11y/accessible/tests/mochitest/role.js:197:5
[task 2021-09-08T15:30:15.926Z] 15:30:15     INFO - testAccessibleTree@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:487:15
[task 2021-09-08T15:30:15.926Z] 15:30:15     INFO - testAccessibleTree@chrome://mochitests/content/a11y/accessible/tests/mochitest/common.js:701:27
[task 2021-09-08T15:30:15.926Z] 15:30:15     INFO - doTest@chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_txtctrl.xhtml:52:25
[task 2021-09-08T15:30:15.927Z] 15:30:15     INFO - TEST-PASS | accessible/tests/mochitest/tree/test_txtctrl.xhtml | Wrong first child of ['img node', address: [object HTMLImageElement], role: graphic, name: 'Clear', address: 0x7fef0c92a0b0]
Flags: needinfo?(nbaumgardner)
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d9383eed75f1 Convert &searchTextBox.clear.label; to fluent. r=emalysz,fluent-reviewers,flod,dao,morgan

https://hg.mozilla.org/mozilla-central/rev/d9383eed75f1

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Flags: needinfo?(nbaumgardner)
Blocks: 1734255
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: