Closed
Bug 1535182
Opened 6 years ago
Closed 6 years ago
Export BaseControlMixin and MozElementMixin through MozElements instead of directly on window
Categories
(Toolkit :: XUL Widgets, task, P5)
Toolkit
XUL Widgets
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: bgrins, Assigned: aswan)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This is just a code cleanup - these two classes were attached onto the window before we had MozElements and never got updated: https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/toolkit/content/customElements.js#492-493.
|
||
Updated•6 years ago
|
Mentor: bgrinstead
Keywords: good-first-bug
|
|
||
Updated•6 years ago
|
Priority: -- → P5
|
Reporter | |
Comment 1•6 years ago
|
||
These references should change from MozElementMixin to MozElements.MozElementMixin:
https://searchfox.org/mozilla-central/search?q=MozElementMixin&path=
And these references should change from BaseControlMixin to MozElements.BaseControlMixin:
https://searchfox.org/mozilla-central/search?q=BaseControlMixin&path=
|
|
Reporter | |
Updated•6 years ago
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
There's a lot of orange here but they all look like known intermittents:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a5604a37e03d93bae4c692748f1f32138bd1ec2
|
||
Updated•6 years ago
|
Attachment #9053471 -
Attachment description: Bug 1535182 Remove BaseElementMixin and MozElementMixwin from window global r=bgrins → Bug 1535182 Remove BaseElementMixin and MozElementMixin from window global r=bgrins
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/912818869def
Remove BaseElementMixin and MozElementMixin from window global r=bgrins
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
||
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•