Open Bug 1535331 Opened 6 years ago Updated 2 years ago

Make about:newtab use JSWindowActors

Categories

(Firefox :: New Tab Page, task)

task

Tracking

()

Fission Milestone Future

People

(Reporter: mconley, Unassigned)

References

(Blocks 1 open bug)

Details

This is required in order to make (at least) about:tabcrashed work.

Depends on: 1535408
Priority: -- → P2
No longer blocks: 1533955
Blocks: 1558832

Bug 1533951 made remote pages support actors, so let's use this bug to handle cleaning up all the unneeded code once all the remote page manager consumers have been ported over.

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → ?

Tracking for Fission Nightly (M6)

Fission Milestone: ? → M6

(In reply to Neil Deakin from comment #1)

Bug 1533951 made remote pages support actors, so let's use this bug to handle cleaning up all the unneeded code once all the remote page manager consumers have been ported over.

Neil, does this bug (to clean up unneeded code) need to block shipping Fission?

Have all the remote page manager consumers been ported? Are there bugs for porting them?

Tentatively taracking for Fission M6c Nightly milestone.

Fission Milestone: M6 → M6c
Flags: needinfo?(enndeakin)

Only the newtab page remains to be ported over. Redirecting the question to Mike for what the status is there.

There's also the tabswitch talos test that needs modifying but that is low priority.

Flags: needinfo?(enndeakin) → needinfo?(mconley)

(In reply to Neil Deakin from comment #5)

Only the newtab page remains to be ported over. Redirecting the question to Mike for what the status is there.

I assume that is about:newtab bug 1648513?

There's also the tabswitch talos test that needs modifying but that is low priority.

Is there a bug # for fixing the tabswitch talos test?

Flags: needinfo?(enndeakin)

(In reply to Chris Peterson [:cpeterson] from comment #6)

(In reply to Neil Deakin from comment #5)

Only the newtab page remains to be ported over. Redirecting the question to Mike for what the status is there.

I assume that is about:newtab bug 1648513?

I actually am not aware yet of a bug on file to port about:home / about:newtab to using JSWindowActors. But this shouldn't block Fission - about:home/about:newtab are pages that don't use out-of-process subframes. So porting them to JSWindowActors is more of a future-proofing thing. It would be good to do in the near-ish term to unfork the RemotePageManager stuff, but it shouldn't block Fission on Nightly.

Flags: needinfo?(mconley)
Type: defect → task
Fission Milestone: M6c → Future
Priority: P2 → P3
Summary: Make RemotePageManager Fission-compatible → Make about:newtab use JSWindowActors

I filed 1663647 on the tabswitch test.

Flags: needinfo?(enndeakin)

ActivityStreamMessageChannel is still using RemotePageManager, which internally still use the MessageManager that we would like to get rid off remaining use.

Severity: normal → N/A
Component: General → New Tab Page
Priority: P3 → --
You need to log in before you can comment on or make changes to this bug.