Closed Bug 1535582 Opened 6 years ago Closed 6 years ago

[de-xbl] nuke now unused bindings xbl-menulist, menulist-popuponly, menulist-editable, panellist, datetextpicker, datetimepicker-base, and fix menulist.css inclusion.

Categories

(Thunderbird :: General, task)

Product:
Thunderbird
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 67.0

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

(Whiteboard: [for landing, needs patch from bug 1524508 applied first])

Attachments

(1 file, 1 obsolete file)

bug1535582_nuke_menulist.xml
(deleted), patch
mkmelin
: review+
Details | Diff | Splinter Review

After bug 1524508 lands the xbl menulist binding can go

I also found a bunch of other bindings that got left behind, so I'm removing

  • xbl-menulist
  • menulist-popuponly
  • menulist-editable
  • panellist,
  • datetextpicker
  • datetimepicker-base

menulist.css inclusing should be for the skin, so I'm fixed that too.

Attached patch bug1535582_nuke_menulist.xml (obsolete) (deleted) — — Splinter Review

Off to try - https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d44d2ac62905de4763b9335e831419c9a6b904e3

Attachment #9051251 - Flags: review?(geoff)
Attachment #9051251 - Attachment is patch: true
Attachment #9051251 - Attachment mime type: text/xml → text/plain
Comment on attachment 9051251 [details] [diff] [review]
bug1535582_nuke_menulist.xml

Review of attachment 9051251 [details] [diff] [review]:
-----------------------------------------------------------------

Nice clean-up.

::: calendar/base/content/dialogs/calendar-event-dialog-recurrence.xul
@@ +12,5 @@
>  <?xml-stylesheet type="text/css" href="chrome://calendar/content/widgets/calendar-widget-bindings.css"?>
>  <?xml-stylesheet type="text/css" href="chrome://calendar/content/calendar-event-dialog.css"?>
>  <?xml-stylesheet type="text/css" href="chrome://calendar/content/datetimepickers/datetimepickers.css"?>
>  <?xml-stylesheet type="text/css" href="chrome://lightning-common/skin/datetimepickers.css"?>
> +<?xml-stylesheet type="text/css" href="chrome://messenger/skin/menulist.css"?>

Not needed as datetimepickers.css is already linked.

::: calendar/lightning/content/lightning-item-iframe.xul
@@ +17,5 @@
>  <?xml-stylesheet type="text/css" href="chrome://lightning-common/skin/datetimepickers.css"?>
>  <?xml-stylesheet type="text/css" href="chrome://messenger/skin/primaryToolbar.css"?>
>  <?xml-stylesheet type="text/css" href="chrome://messenger/skin/messenger.css"?>
>  <?xml-stylesheet type="text/css" href="chrome://calendar-common/skin/dialogs/calendar-event-dialog.css"?>
> +<?xml-stylesheet type="text/css" href="chrome://messenger/skin/menulist.css"?>

And here.

::: calendar/resources/content/datetimepickers/datetimepickers.css
@@ +6,3 @@
>  
>  timepicker-grids {
>    display: -moz-box;

This one remaining rule is unneeded. Let's get rid of this file too.

The import can go in calendar/resources/skin/datetimepickers.css.
Attachment #9051251 - Flags: review?(geoff) → review+
Attached patch bug1535582_nuke_menulist.xml (deleted) — — Splinter Review
Attachment #9051251 - Attachment is obsolete: true
Attachment #9051532 - Flags: review+
Keywords: checkin-needed
Whiteboard: [for landing, needs patch from bug 1524508 applied first]
Attachment #9051532 - Attachment is patch: true
Attachment #9051532 - Attachment mime type: text/xml → text/plain

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/34babfc74629
nuke now unused bindings xbl-menulist, menulist-popuponly, menulist-editable, panellist, datetextpicker, datetimepicker-base, and fix menulist.css inclusion. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 67.0
Type: defect → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: