Closed Bug 1535773 Opened 6 years ago Closed 6 years ago

Allow collapsing of top sites and the rest of Discovery Stream content

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Version:
67 Branch
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 68
Iteration:
68.2 - Apr 1 - 14
Tracking Flags:
Tracking Status
firefox67 --- wontfix
firefox68 --- verified

People

(Reporter: wolasi, Assigned: Mardak)

References

Details

(Keywords: github-merged)

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4890
(deleted), text/x-github-pull-request
Details

We’re bring back some of the original Section Actions to New Tab. And exposing the Collapse/Expand action in the Section Header.

Section Header Components

  • Collapse/Expand Button
  • Section Title
  • Optional Info Link
  • Open Menu Button
  • Section Menu (triggered by the Open Menu button)

Implementation Details

  • Let's reuse as much of the existing Section Menu code as possible.
  • Note Actions available in the menu depend on the section.
  • Note For the section content collapse and expand UX we'll need to create container for each section, and track the section content collapse/expand state.

Spec
https://codepen.io/otbog/pen/XGEOxZ?editors=1100
https://www.figma.com/file/0xZkmT86rSXbGRB4eIvrn0ts/Home-New-Tab-Spec-for-Fx-v68?node-id=12%3A0

Flags: needinfo?(wkonu)
Flags: needinfo?(wkonu)
Keywords: uiwanted
Summary: Update Section Header component → Update Section Header component to bring back collapsing
Priority: -- → P1

There might be some overlap with bug 1533601 although SectionManager separately tracked whether a section should show via about:config prefs while collapsed was via indexedb.

Currently I don't think there's any per-discovery-stream-section state, so some storage mechanism is needed ?

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1533601
No longer blocks: 1512725
Keywords: uiwanted

Hi everyone,

Is this bug available? If so, I would be interest in working on it!

Thanks.

Severity: normal → enhancement
Iteration: 68.1 - Mar 18 - 31 → 68.2 - Apr 1 - 14

Thank you for volunteering, Mellina! This bug is not currently available for contribution, but please check out this wiki page to find a good next step: https://wiki.mozilla.org/Good_first_bug Thanks again!

Assignee: nobody → pdahiya
Blocks: 1543442

Renaming to reflect the reduction of scope. The more general approach with server controllable collapsible is being tracked in bug 1542866.

Assignee: pdahiya → edilee
Blocks: 1542866
Summary: Update Section Header component to bring back collapsing → Allow collapsing of top sites and the rest of Discovery Stream content
Blocks: 1543756

https://hg.mozilla.org/mozilla-central/rev/7a435211fa07

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190414214746) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the sections can be collapsed/expanded and a section menu is present for the "Top Sites" and the "Recommended by Pocket" sections containing the following options:

Options for the "Top Sites" section:

  • Add Top Site:
  • Add Search Engine
  • Remove Section
  • Collapse/Expand Section
  • Manage Section

Options for the "Recommended by Pocket" section:

  • Remove Section
  • Collapse/Expand Section
  • Privacy Notice
  • Manage Section
Status: RESOLVED → VERIFIED
status-firefox68: fixed → verified
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: