Huge memory usage when open the demo due to lots of text-shadow
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
People
(Reporter: nayinain, Assigned: nical)
References
Details
Attachments
(6 files, 5 obsolete files)
render tasks for the test case
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
Steps to reproduce:
- Enable WebRender
- Open the demo.html
Actual results:
Huge memory usage.
Expected results:
Sorry for my bad English.
|
||
Updated•6 years ago
|
|
|
||
Comment 2•6 years ago
|
||
This page has a single character with nearly 200 text shadow that are spread all over the place. I suspect we're allocating lots of really large render targets.
|
Assignee | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
|
|
Assignee | |
Comment 4•6 years ago
|
||
The shiny new render task dump in wr captures show that we do indeed create a huge amount of very large render tasks.
|
|
||
Comment 6•5 years ago
|
||
This was fixed by bug 1545768
|
|
Assignee | |
Comment 7•5 years ago
|
||
|
|
Assignee | |
Comment 8•5 years ago
|
||
|
|
Assignee | |
Comment 9•5 years ago
|
||
|
|
Assignee | |
Comment 10•5 years ago
|
||
|
|
Assignee | |
Comment 11•5 years ago
|
||
|
|
Assignee | |
Comment 12•5 years ago
|
||
|
|
Assignee | |
Comment 13•5 years ago
|
||
Here is the first wave of shadow stack patches. Rebasing was quite brutal and I didn't manage to keep all commits from https://github.com/servo/webrender/pull/3636 building independently so the bulk of the shadow stack implementation ended up in the same commit.
The next patch to come after this lands will remove the non-stack shadow code paths and to use the shadow stack path for all picture composite filter ops.
After that the remaining work is to detect shadow stacks in built from push/pop shadow display items and express them in terms of picture composite ops instead of using the shadow items code, and eventually remove the shadow item code entirely.
Once all of this is done, this test case should be able to de-duplicate a lot of render tasks and consume a lot less memory, although there is quite a bit of render task memory associated to other things like masks that needs to be investigated.
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 14•5 years ago
|
||
Pushed by nsilva@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d8bd0fd80579 Shadow stack implementation. r=kvark https://hg.mozilla.org/integration/mozilla-inbound/rev/82e5affb98af Sanitize filters in place. r=kvark https://hg.mozilla.org/integration/mozilla-inbound/rev/bcbaf50dca28 Gecko side changes. r=kvark
|
||
Comment 15•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d8bd0fd80579
https://hg.mozilla.org/mozilla-central/rev/82e5affb98af
https://hg.mozilla.org/mozilla-central/rev/bcbaf50dca28
|
|
Assignee | |
Comment 16•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 17•5 years ago
|
||
sed -i 's/RenderTaskTree/RenderTaskGraph/g' gfx/wr/webrender//*.rs
sed -i 's/task tree/task graph/g' gfx/wr/webrender//*.rs
|
|
||
Comment 18•5 years ago
|
||
Comment on attachment 9064427 [details]
Bug 1536021 - Remove the single-shadow picture composite code. r=kvark
Revision D30896 was moved to bug 1551187. Setting attachment 9064427 [details] to obsolete.
|
|
||
Comment 19•5 years ago
|
||
Comment on attachment 9064432 [details]
Bug 1536021 - Rename render task tree into render task graph. r=kvark
Revision D30897 was moved to bug 1551187. Setting attachment 9064432 [details] to obsolete.
|
|
Assignee | |
Updated•5 years ago
|
Description
•