Closed Bug 1536029 Opened 6 years ago Closed 3 years ago

Vendor pytest-mock via |mach vendor python|

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: whimboo, Unassigned)

References

Details

Attachments

(1 obsolete file)

Since bug 1464082 we have pytest vendored in tree now, but for a variety of tests it would be great if we could also switch from the mock package to pytest-mock.

Vendoring the required packages will be done via:

$ ./mach vendor python pytest-mock==1.10.1

Running this locally I can see dependencies on mock, and pbr.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Blocks: 1536060

Andrew, I stumbled over this 3 years old bug and wonder how our strategy is nowadays. I cannot see pytest anymore under the Python vendored packages. We still have mozbase packages that use pytest for their unit tests. So where is pytest coming from?

Further I don't have a usecase for pytest-mock right now given that I haven't worked on mozbase for quite some time, but maybe it would still be helpful to have?

Assignee: hskupin → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(ahal)

The dependency on pytest is now defined here, we don't need to vendor it anymore (🎉).
If we added pytest-mock, I'd recommend adding it to that file.

I'll personally give you a 🤷 on pytest-mock over the builtin unittest.mock module, but I trust the judgement of you two :)

Yeah, I don't have any opinions or knowledge on what pytest-mock offers over the built-in one. So if you want to use it I'd say go ahead and add it (via pypi not via vendor).

Flags: needinfo?(ahal)
Attachment #9051649 - Attachment is obsolete: true

Given that there is no need for me right now I'm going to close as incomplete.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: