Add a wrench debug option to dump concatenated shader source to file.
Categories
(Core :: Graphics: WebRender, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: gw, Assigned: gw)
References
Details
(Whiteboard: [wr-amvp][wr-q2])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
This can be very useful to enable passing the output through other tools (e.g. mobile platform shader analyzers during shader optimization work).
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Comment 2•5 years ago
|
||
Hi, I would like to work on this bug. Could I get some pointers on a good place to start?
Comment 3•5 years ago
|
||
Glenn should be asleep, but in case it helps, this could be a good place to start:
compute_source
gives you the full shader source.
Comment 4•5 years ago
|
||
(written in collision with :emilio response)
You can start by looking at the shader loading and the corresponding low level functions do_build_shader_string and link_program. Please reach out if you have any questions!
Comment 5•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb8c60790fd9
Add debug option to wrench to output specified shader source r=kvark
Comment 7•5 years ago
|
||
Backed out changeset cb8c60790fd9 (Bug 1536240) for causing build bustages CLOSED TREE
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=cb8c60790fd9a7fcd503e97b83de101daee39e77&selectedJob=249214807
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249214803&repo=autoland&lineNumber=24295
Backout: https://hg.mozilla.org/integration/autoland/rev/6d98129734a866e3b8d97b8397b88022d863a7d8
Comment 8•5 years ago
|
||
Looks like the WR bindings fail to build.
Connor, please build and run Firefox for testing before proceeding with the change (try push would be best, but in this case it's not that important).
Comment 9•5 years ago
|
||
Apologies for that!
try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f2847434eb36758949737f2a599c5b3333f5b23
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57861a1ded5a
Add debug option to wrench to output specified shader source r=kvark
Comment 11•5 years ago
|
||
bugherder |
Description
•