Closed Bug 1536467 Opened 6 years ago Closed 6 years ago

TypeError: this.populateSendTabToDevicesMenu is not a function when opening "send tab to device" early enough on startup (no sync has happened yet)

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Version:
67 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox67 --- verified
firefox68 --- verified

People

(Reporter: Gijs, Assigned: vbudhram)

References

Details

Attachments

(1 file)

Bug 1536467 - bind callbacks to `this` for Send Tab to Device subview so they work when we're waiting for the initial sync
(deleted), text/x-phabricator-request
Details

The callback situation here presumably means this is no longer bound correctly.

STR:

  1. enable session restore
  2. sign into sync
  3. ensure there's another device in your sync account
  4. open a page you can "send to device"
  5. restart
  6. quickly open the account menu, click "send tab to device"

ER:

Initially it displays "Syncing devices..." and then it shows the devices

AR:
it never shows devices until you close and reopen.

Assignee: nobody → vbudhram
Attachment #9052066 - Attachment description: Bug 1536467 - Use gSync instead of this for Send Tab to Device → Bug 1536467 - bind callbacks to `this` for Send Tab to Device subview so they work when we're waiting for the initial sync
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4dedf93bfe2d bind callbacks to `this` for Send Tab to Device subview so they work when we're waiting for the initial sync r=Gijs

https://hg.mozilla.org/mozilla-central/rev/4dedf93bfe2d

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Flags: qe-verify+

I’ve reproduced this issue on Nightly 68.0a1 (2019-03-18) with Windows 10 x64.
The issue is verified fixed on Nightly 68.0a1 (2019-04-08) and Beta 67.0b9 with Windows 10 x64, macOS 10.13 and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
status-firefox67: fixed → verified
status-firefox68: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: