Closed Bug 1536517 Opened 6 years ago Closed 6 years ago

Date-picker control not visible in Custom Reminder dialog and Print Preview dialog

Categories

(Calendar :: Dialogs, defect)

Product:
Calendar
Component:
Dialogs
Version:
Lightning 6.9
Platform:
Desktop
Windows 10
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ssitter, Assigned: jorgk-bmo)

References

Details

(Keywords: regression)

Attachments

(5 files, 1 obsolete file)

custom_reminder
(deleted), image/png
Details
print_preview.png
(deleted), image/png
Details
cal-print.png
(deleted), image/png
Details
1536517-CE-scripts.patch
(deleted), patch
darktrojan
: review+
Details | Diff | Splinter Review
1536517-remove-CE.patch
(deleted), patch
darktrojan
: review+
Fallen
: approval-calendar-beta+
Details | Diff | Splinter Review
Attached image custom_reminder (deleted) —

Thunderbird 67.0a1 (BuildID 20190317094532)

I tried to validate Bug 1515956 when I noticed that the date-picker control is not visible in the custom reminder dialog. No errors are reported in the error console.

Attached image print_preview.png (deleted) —

Same problem exists in the print preview dialog.

Attachment #9052048 - Attachment description: screenshots.png → custom_reminder
Summary: Custom reminder dialog: date-picker control not visible → Date-picker control not visible in Custom Reminder dialog and Print Preview dialog

Maybe regression from Bug 1524456?

Looks like a similar fix to bug 1532021 is required:
https://hg.mozilla.org/comm-central/rev/6716eb6db611

And we need to fix this on the beta.

Attached patch 1536517-CE-scripts.patch (obsolete) (deleted) — — Splinter Review
Attachment #9053127 - Flags: review?(geoff)
Attached image cal-print.png (deleted) —

Hmm, the date pickers work now, but showing HTML as plaintext in the preview is not strictly a winner :-( - That's for another bug.

Attachment #9053127 - Flags: approval-calendar-beta?(philipp)
Attachment #9053127 - Flags: review?(geoff) → review+

Actually, I think there's a stylesheet missing too. Just a mo, I'll check.

calendar-print-dialog.xul needs chrome://lightning-common/skin/datetimepickers.css, and the other stylesheet tags are a bit broken on it too.

Attached patch 1536517-CE-scripts.patch (deleted) — — Splinter Review

Fixed the CSS mess as well now.

Assignee: nobody → jorgk
Attachment #9053159 - Flags: review?(geoff)
Attachment #9053159 - Flags: approval-calendar-beta?(philipp)
Attachment #9053127 - Attachment is obsolete: true
Attachment #9053127 - Flags: approval-calendar-beta?(philipp)
Comment on attachment 9053159 [details] [diff] [review] 1536517-CE-scripts.patch That looks better.
Attachment #9053159 - Flags: review?(geoff) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fe82189269f7
Add missing scripts to show custom element datetimepickers in reminder and print dialogues. r=darktrojan

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED

This needs target 6.10.

Flags: needinfo?(philipp)
Target Milestone: --- → 6.9
Comment on attachment 9053159 [details] [diff] [review] 1536517-CE-scripts.patch TB 67 beta, Cal 6.9: https://hg.mozilla.org/releases/comm-beta/rev/6bbf829da9c19d9b3bb1ab7c5749bbb579771201
Flags: needinfo?(philipp)
Attachment #9053159 - Flags: approval-calendar-beta?(philipp)
Depends on: 1538688
Attached patch 1536517-remove-CE.patch (deleted) — — Splinter Review

I tried the attendee dialogue (bug 1532021) and the reminder dialogue and the print dialogue without customElements.js. Attendees and reminder malfunction, only print is still OK. So only removing it there.

Attachment #9053520 - Flags: review?(geoff)
Attachment #9053520 - Flags: review?(geoff) → review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/67f8c115476e Follow-up: remove customElements.js from print dialogue since it's not needed. r=darktrojan
Comment on attachment 9053520 [details] [diff] [review] 1536517-remove-CE.patch Should the followup fix land on beta as well?
Attachment #9053520 - Flags: approval-calendar-beta?(philipp)
Attachment #9053520 - Flags: approval-calendar-beta?(philipp) → approval-calendar-beta+

TB 67 beta 2 / Cal 6.9, sorry, I missed the follow-up for beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/1aa74c7d1f80c8cc009e32347cc6a773cc903328

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: