Closed Bug 1536730 Opened 6 years ago Closed 6 years ago

sidebar requires click to receive mouse events

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P3)

68 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla68
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 --- verified

People

(Reporter: st, Assigned: hsivonen)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

  • I'm using today's nightly build (68.0a1 2019-03-19, Linux 64-bit)

  • Start Firefox with a new, temporary profile:

    $ rm -rf /run/user/1000/temp-profile
    $ mkdir -p /run/user/1000/temp-profile
    $ ~/Downloads/firefox/firefox -noremote -profile /run/user/1000/temp-profile
    
  • Install the Tree Style Tab addon from https://addons.mozilla.org/en-US/firefox/addon/tree-style-tab/

  • Once the addon is installed, it opens a list of tabs in the sidebar, which should have four tabs in it (the Firefox first run page, a privacy notice, the a.m.o page for TST, and the TST first run page)

Actual results:

  • Move the mouse over the tabs in the sidebar, notice that there are no :hover effects
  • Click on the sidebar content, then move the mouse again, and notice that now tabs change color on :hover
  • Click on a different tab in the sidebar to switch to it, then move the mouse again, and notice that :hover effects have ceased
  • Try to close a tab in the sidebar, notice you need to click once to get it to respond to mouse events, then click again to make the thing happen

Generally, everything in the sidebar now takes an extra click. If you have enough tabs open, even scrolling with the mouse-wheel requires a click before it works.

Also, once you've clicked in the sidebar, you need to select a different tab, or click back on the main content area before :hover or clicks register there.

Expected results:

Sidebar content should always respond to mouse-hover and click, without the extra "activating" click.

Note that this doesn't seem to affect browser-supplied sidebars like Bookmarks or History.. It does seem to affect the Downloads Sidebar addon (https://addons.mozilla.org/en-US/firefox/addon/downloads-sidebar/), or any webpage opened in the sidebar with the Open In Sidebar addon (https://addons.mozilla.org/en-US/firefox/addon/open-link-in-sidebar/?src=search)

Blocks: 1535541
Status: UNCONFIRMED → NEW
Component: Untriaged → DOM: Events
Ever confirmed: true
Keywords: regression
Product: Firefox → Core
Flags: needinfo?(hsivonen)
Priority: -- → P3
Component: DOM: Events → User events and focus handling

Should probably check event class before performing focus-based routing.

Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Flags: needinfo?(hsivonen)
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/76ec247785a8 Avoid using keyboard focus for routing mouse events meant for a sidebar. r=nika
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Blocks: 1541088
No longer blocks: 1535541
Regressed by: 1535541
No longer blocks: 1541088
Regressions: 1541088

Verified as fixed in latest FF68.
I will attach a post fix video

Status: RESOLVED → VERIFIED
Attached image Postfix Screenshot (deleted) —
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: